Small fix to QgsDataDefined implicit sharing

qgis · May 9, 2015 · 4a4877d · 4a4877d
1 parent 65cd9fc
commit 4a4877d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/core/qgsdatadefined.cpp b/src/core/qgsdatadefined.cpp
@@ -210,7 +210,10 @@ bool QgsDataDefined::expressionIsPrepared() const
 
 QgsExpression *QgsDataDefined::expression()
 {
-  d.detach();
+  //Ideally there should be a detach here, but that causes issues
+  //as detaching can create a new expression which will be unprepared
+  //TODO - revisit after QgsExpression is made implicitly shared
+  //d.detach();
   return d->expression;
 }