deduplicate duplicate code

qgis · Apr 1, 2023 · 495a76a · 495a76a
1 parent 3574972
commit 495a76a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 14 deletions.
diff --git a/src/server/services/wms/qgswmsrenderer.cpp b/src/server/services/wms/qgswmsrenderer.cpp
@@ -144,13 +144,8 @@ namespace QgsWms
     }
     else
     {
-      context.setScaleFactor( mContext.dotsPerMm() );
-      const double mmPerMapUnit = 1 / QgsServerProjectUtils::wmsDefaultMapUnitsPerMm( *mProject );
-      context.setMapToPixel( QgsMapToPixel( 1 / ( mmPerMapUnit * context.scaleFactor() ) ) );
-      QgsDistanceArea distanceArea;
-      distanceArea.setSourceCrs( QgsCoordinateReferenceSystem( mWmsParameters.crs() ), mProject->transformContext() );
-      distanceArea.setEllipsoid( geoNone() );
-      context.setDistanceArea( distanceArea );
+      //use default scale settings
+      configureDefaultRenderContext( context );
     }
 
     // create image according to context
@@ -216,13 +211,7 @@ namespace QgsWms
 
     // create context
     QgsRenderContext context = QgsRenderContext::fromQPainter( painter.get() );
-    context.setScaleFactor( mContext.dotsPerMm() );
-    const double mmPerMapUnit = 1 / QgsServerProjectUtils::wmsDefaultMapUnitsPerMm( *mProject );
-    context.setMapToPixel( QgsMapToPixel( 1 / ( mmPerMapUnit * context.scaleFactor() ) ) );
-    QgsDistanceArea distanceArea = QgsDistanceArea();
-    distanceArea.setSourceCrs( QgsCoordinateReferenceSystem( mWmsParameters.crs() ), mProject->transformContext() );
-    distanceArea.setEllipsoid( geoNone() );
-    context.setDistanceArea( distanceArea );
+    configureDefaultRenderContext( context );
     ctx.context = &context;
 
     nodeModel.drawSymbol( settings, &ctx, size.height() / dpmm );
@@ -1392,6 +1381,17 @@ namespace QgsWms
     }
   }
 
+  void QgsRenderer::configureDefaultRenderContext( QgsRenderContext &context )
+  {
+    context.setScaleFactor( mContext.dotsPerMm() );
+    const double mmPerMapUnit = 1 / QgsServerProjectUtils::wmsDefaultMapUnitsPerMm( *mProject );
+    context.setMapToPixel( QgsMapToPixel( 1 / ( mmPerMapUnit * context.scaleFactor() ) ) );
+    QgsDistanceArea distanceArea = QgsDistanceArea();
+    distanceArea.setSourceCrs( QgsCoordinateReferenceSystem( mWmsParameters.crs() ), mProject->transformContext() );
+    distanceArea.setEllipsoid( geoNone() );
+    context.setDistanceArea( distanceArea );
+  }
+
   QDomDocument QgsRenderer::featureInfoDocument( QList<QgsMapLayer *> &layers, const QgsMapSettings &mapSettings,
       const QImage *outputImage, const QString &version ) const
   {

diff --git a/src/server/services/wms/qgswmsrenderer.h b/src/server/services/wms/qgswmsrenderer.h
@@ -195,6 +195,12 @@ namespace QgsWms
        */
       void configureMapSettings( const QPaintDevice *paintDevice, QgsMapSettings &mapSettings, bool mandatoryCrsParam = true );
 
+      /**
+       * Configures QgsRenderContext according to the WMS parameters and default settings. Used, for example, when no mapSettings are available.
+       * \param context render context keeping info about the scale
+       */
+      void configureDefaultRenderContext( QgsRenderContext &context );
+
       QDomDocument featureInfoDocument( QList<QgsMapLayer *> &layers, const QgsMapSettings &mapSettings,
                                         const QImage *outputImage, const QString &version ) const;