Fix double clear actions sometimes show in spin boxes

nyalldawson · nyalldawson · commit 494f7bcde1be · 2018-06-13T19:23:25.000+10:00
Fixes #19178
diff --git a/src/gui/qgsfilterlineedit.cpp b/src/gui/qgsfilterlineedit.cpp
@@ -73,6 +73,12 @@ void QgsFilterLineEdit::updateClearIcon()
   }
   else if ( !showClear && mClearAction )
   {
+    // pretty freakin weird... seems the deleteLater call on the mClearAction
+    // isn't sufficient to actually remove the action from the line edit, and
+    // a kind of "ghost" action gets left behind... resulting in duplicate
+    // clear actions appearing if later we re-create the action.
+    // in summary: don't remove this "removeAction" call!
+    removeAction( mClearAction );
     mClearAction->deleteLater();
     mClearAction = nullptr;
   }

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,12 @@ void QgsFilterLineEdit::updateClearIcon()`
`73`	`73`	`}`
`74`	`74`	`else if ( !showClear && mClearAction )`
`75`	`75`	`{`
	`76`	`+ // pretty freakin weird... seems the deleteLater call on the mClearAction`
	`77`	`+ // isn't sufficient to actually remove the action from the line edit, and`
	`78`	`+ // a kind of "ghost" action gets left behind... resulting in duplicate`
	`79`	`+ // clear actions appearing if later we re-create the action.`
	`80`	`+ // in summary: don't remove this "removeAction" call!`
	`81`	`+ removeAction( mClearAction );`
`76`	`82`	`mClearAction->deleteLater();`
`77`	`83`	`mClearAction = nullptr;`
`78`	`84`	`}`