Fix double clear actions sometimes show in spin boxes

Fixes #19178
qgis · Jun 13, 2018 · 494f7bc · 494f7bc
1 parent dab4437
commit 494f7bc
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/gui/qgsfilterlineedit.cpp b/src/gui/qgsfilterlineedit.cpp
@@ -73,6 +73,12 @@ void QgsFilterLineEdit::updateClearIcon()
   }
   else if ( !showClear && mClearAction )
   {
+    // pretty freakin weird... seems the deleteLater call on the mClearAction
+    // isn't sufficient to actually remove the action from the line edit, and
+    // a kind of "ghost" action gets left behind... resulting in duplicate
+    // clear actions appearing if later we re-create the action.
+    // in summary: don't remove this "removeAction" call!
+    removeAction( mClearAction );
     mClearAction->deleteLater();
     mClearAction = nullptr;
   }