Explicitly mention in docs that presence of destination CRS does

not affect filter expressions or virtual field values
qgis · Jun 8, 2017 · 482ed3f · 482ed3f
1 parent e437812
commit 482ed3f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/python/core/qgsfeaturerequest.sip b/python/core/qgsfeaturerequest.sip
@@ -568,6 +568,15 @@ Set a subset of attributes by names that will be fetched
  set on the request is expected to be in the same CRS as the destination
  CRS.
 
+ The feature geometry transformation to the destination CRS is performed
+ after all filter expressions are tested and any virtual fields are
+ calculated. Accordingly, any geometric expressions used in
+ filterExpression() will be performed in the original
+ source CRS. This ensures consistent results are returned regardless of the
+ destination CRS. Similarly, virtual field values will be calculated using the
+ original geometry in the source CRS, so these values are not affected by
+ any destination CRS transform present in the feature request.
+
 .. seealso:: destinationCrs()
 .. versionadded:: 3.0
  :rtype: QgsFeatureRequest

diff --git a/src/core/qgsfeaturerequest.h b/src/core/qgsfeaturerequest.h
@@ -522,6 +522,15 @@ class CORE_EXPORT QgsFeatureRequest
      * set on the request is expected to be in the same CRS as the destination
      * CRS.
      *
+     * The feature geometry transformation to the destination CRS is performed
+     * after all filter expressions are tested and any virtual fields are
+     * calculated. Accordingly, any geometric expressions used in
+     * filterExpression() will be performed in the original
+     * source CRS. This ensures consistent results are returned regardless of the
+     * destination CRS. Similarly, virtual field values will be calculated using the
+     * original geometry in the source CRS, so these values are not affected by
+     * any destination CRS transform present in the feature request.
+     *
      * \see destinationCrs()
      * \since QGIS 3.0
      */