Render WFS layers added when 'Keep dialog open' is enabled (#14935)

rouault · rouault · commit 47a301ca61a9 · 2016-06-01T10:54:48.000+02:00
And remove a few left overs (MapCRS, MapExtent) that were only used
by the provider in QGIS &lt;= 2.14.

It is not completely obvious why the canevas refresh was disabled
before while the dialog is opened. Perhaps a conflict with the
previous Load GML progress dialog that was modal ?
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -4062,11 +4062,6 @@ void QgisApp::addWcsLayer()
 
 void QgisApp::addWfsLayer()
 {
-  if ( !mMapCanvas )
-  {
-    return;
-  }
-
   QgsDebugMsg( "about to addWfsLayer" );
 
   // TODO: QDialog for now, switch to QWidget in future
@@ -4079,17 +4074,7 @@ void QgisApp::addWfsLayer()
   connect( wfss, SIGNAL( addWfsLayer( QString, QString ) ),
            this, SLOT( addWfsLayer( QString, QString ) ) );
 
-  //re-enable wfs with extent setting: pass canvas info to source select
-  wfss->setProperty( "MapExtent", mMapCanvas->extent().toString() );
-  if ( mMapCanvas->mapSettings().hasCrsTransformEnabled() )
-  { //if "on the fly" reprojection is active, pass canvas CRS
-    wfss->setProperty( "MapCRS", mMapCanvas->mapSettings().destinationCrs().authid() );
-  }
-
-  bool bkRenderFlag = mMapCanvas->renderFlag();
-  mMapCanvas->setRenderFlag( false );
   wfss->exec();
-  mMapCanvas->setRenderFlag( bkRenderFlag );
   delete wfss;
 }
 
