Silence some false-positive cppcheck warnings, add explanation comments

qgis · Apr 17, 2023 · 477a647 · 477a647
1 parent 06aded9
commit 477a647
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 0 deletions.
diff --git a/src/core/mesh/qgsmeshtracerenderer.cpp b/src/core/mesh/qgsmeshtracerenderer.cpp
@@ -249,6 +249,7 @@ QgsMeshStreamField::QgsMeshStreamField( const QgsMeshStreamField &other )
   , mPen( other.mPen )
   , mTraceImage( other.mTraceImage )
   , mMapToFieldPixel( other.mMapToFieldPixel )
+  , mOutputExtent( other.mOutputExtent )
   , mVectorColoring( other.mVectorColoring )
   , mDirectionField( other.mDirectionField )
   , mRenderContext( other.mRenderContext )
@@ -261,6 +262,7 @@ QgsMeshStreamField::QgsMeshStreamField( const QgsMeshStreamField &other )
   , mMaximumMagnitude( other.mMaximumMagnitude )
   , mPixelFillingDensity( other.mPixelFillingDensity )
   , mMinMagFilter( other.mMinMagFilter )
+  , mMaxMagFilter( other.mMaxMagFilter )
   , mMinimizeFieldSize( other.mMinimizeFieldSize )
 {
   mPainter.reset( new QPainter( &mTraceImage ) );
@@ -1136,9 +1138,11 @@ QgsMeshParticleTracesField::QgsMeshParticleTracesField( const QgsMeshParticleTra
   , mParticlesLifeTime( other.mParticlesLifeTime )
   , mParticlesCount( other.mParticlesCount )
   , mTailFactor( other.mTailFactor )
+  , mMinTailLength( other.mMinTailLength )
   , mParticleColor( other.mParticleColor )
   , mParticleSize( other.mParticleSize )
   , mStumpFactor( other.mStumpFactor )
+  , mStumpParticleWithLifeTime( other.mStumpParticleWithLifeTime )
 {}
 
 void QgsMeshParticleTracesField::addParticle( const QPoint &startPoint, double lifeTime )

diff --git a/src/core/proj/qgscoordinatereferencesystem_p.h b/src/core/proj/qgscoordinatereferencesystem_p.h
@@ -62,10 +62,12 @@ class QgsCoordinateReferenceSystemPrivate : public QSharedData
       , mIsValid( other.mIsValid )
       , mCoordinateEpoch( other.mCoordinateEpoch )
       , mPj()
+      , mPjParentContext( nullptr )
       , mProj4( other.mProj4 )
       , mWktPreferred( other.mWktPreferred )
       , mAxisInvertedDirty( other.mAxisInvertedDirty )
       , mAxisInverted( other.mAxisInverted )
+      , mProjLock{}
       , mProjObjects()
     {
     }

diff --git a/src/core/proj/qgscoordinatetransform.cpp b/src/core/proj/qgscoordinatetransform.cpp
@@ -150,6 +150,13 @@ QgsCoordinateTransform::QgsCoordinateTransform( const QgsCoordinateTransform &o
   , mHasContext( o.mHasContext )
 #endif
   , mLastError()
+    // none of these should be copied -- they must be set manually for every object instead, or
+    // we risk contaminating the cache and copies retrieved from cache with settings which should NOT
+    // be applied to all transforms
+  , mIgnoreImpossible( false )
+  , mBallparkTransformsAreAppropriate( false )
+  , mDisableFallbackHandler( false )
+  , mFallbackOperationOccurred( false )
 {
   d = o.d;
 }

diff --git a/src/core/proj/qgscoordinatetransformcontext_p.h b/src/core/proj/qgscoordinatetransformcontext_p.h
@@ -49,6 +49,7 @@ class QgsCoordinateTransformContextPrivate : public QSharedData
 
     QgsCoordinateTransformContextPrivate( const QgsCoordinateTransformContextPrivate &other )
       : QSharedData( other )
+      , mLock{}
     {
       other.mLock.lockForRead();
       mSourceDestDatumTransforms = other.mSourceDestDatumTransforms;