Skip to content

Commit

Permalink
highlight fix
Browse files Browse the repository at this point in the history
  • Loading branch information
@blazek
blazek committed Jun 22, 2017
1 parent 5c6e794 commit 4659691
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/gui/qgshighlight.cpp
View file
Expand Up @@ -257,7 +257,7 @@ void QgsHighlight::paintPolygon( QPainter *p, QgsPolygon polygon )

void QgsHighlight::updatePosition()
{
// nothing to do here...
QgsMapCanvasItem::updatePosition();
}

void QgsHighlight::paint( QPainter *p )
Expand Down

9 comments on commit 4659691

@3nids
Copy link
Member

@3nids 3nids commented on 4659691 Jun 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@nirvn
Copy link
Contributor

@nirvn nirvn commented on 4659691 Jul 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blazek , this commit caused the following regression: https://issues.qgis.org/issues/16824

Is there any actual problem you were trying to fix here?

@3nids , ping, in case you know what this commit was trying to fix, and work on a regression-free alternative 😄

@blazek
Copy link
Member Author

@blazek blazek commented on 4659691 Jul 28, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix resolved this problem:

  1. highlight a feature programmatically when it is outside current map canvas extent
  2. zoom to that feature
  3. the highlight disappears

Please don't simply revert without fixing the original problem.
More info http://lists.osgeo.org/pipermail/qgis-developer/2017-June/048948.html

(I'll be back on Monday)

@nirvn
Copy link
Contributor

@nirvn nirvn commented on 4659691 Aug 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blazek , gentle ping; is a solution being cooked for this regression?

@blazek
Copy link
Member Author

@blazek blazek commented on 4659691 Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not just now but i keep it on mind.

@nyalldawson
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should revert for now - the original issue is less critical then the regression here (since its only evident when using PyQGIS, not day-to-day use). We can recommit when the regression is fixed.

@blazek
Copy link
Member Author

@blazek blazek commented on 4659691 Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, can you revert it? I dont have access to computer this week.

@nirvn
Copy link
Contributor

@nirvn nirvn commented on 4659691 Aug 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3nids , are you OK to revert this for the time being?

@blazek
Copy link
Member Author

@blazek blazek commented on 4659691 Aug 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made another attempt to fix that in dbd86d0. It seems all to be working - zoom, pan, scale, rotate.

Please sign in to comment.