Fixes value relation line edit not found values

When there is no match in the relation layer, show "(no selection)" instead of NOT updating the widget (which was the reported issue). Fixes #38552
qgis · Sep 16, 2020 · 448f7d9 · 448f7d9
1 parent 49037e0
commit 448f7d9
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/gui/editorwidgets/qgsvaluerelationwidgetwrapper.cpp b/src/gui/editorwidgets/qgsvaluerelationwidgetwrapper.cpp
@@ -244,14 +244,22 @@ void QgsValueRelationWidgetWrapper::updateValues( const QVariant &value, const Q
   }
   else if ( mLineEdit )
   {
+    mLineEdit->clear();
+    bool wasFound { false };
     for ( const QgsValueRelationFieldFormatter::ValueRelationItem &i : qgis::as_const( mCache ) )
     {
       if ( i.key == value )
       {
         mLineEdit->setText( i.value );
+        wasFound = true;
         break;
       }
     }
+    // Value could not be found
+    if ( ! wasFound )
+    {
+      mLineEdit->setText( tr( "(no selection)" ) );
+    }
   }
 }