unique_ptr for feedback and add missing includes

qgis · Aug 23, 2021 · 4483ee7 · 4483ee7
1 parent 0034f49
commit 4483ee7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/core/externalstorage/qgswebdavexternalstorage.cpp b/src/core/externalstorage/qgswebdavexternalstorage.cpp
@@ -19,6 +19,7 @@
 #include "qgsblockingnetworkrequest.h"
 #include "qgsnetworkaccessmanager.h"
 #include "qgsapplication.h"
+#include "qgsfeedback.h"
 
 #include <QFile>
 #include <QPointer>
@@ -53,7 +54,7 @@ bool QgsWebDAVExternalStorageStoreTask::run()
     }
   } );
 
-  QgsBlockingNetworkRequest::ErrorCode err = request.put( req, f, mFeedback );
+  QgsBlockingNetworkRequest::ErrorCode err = request.put( req, f, mFeedback.get() );
 
   if ( err != QgsBlockingNetworkRequest::NoError )
   {

diff --git a/src/core/externalstorage/qgswebdavexternalstorage_p.h b/src/core/externalstorage/qgswebdavexternalstorage_p.h
@@ -23,6 +23,7 @@
 #include "externalstorage/qgsexternalstorage.h"
 
 #include <QPointer>
+#include <QUrl>
 
 class QgsWebDAVExternalStorageStoreTask;
 class QgsFetchedContent;
@@ -132,7 +133,7 @@ class QgsWebDAVExternalStorageStoreTask : public QgsTask
     const QUrl mUrl;
     const QString mFilePath;
     const QString mAuthCfg;
-    QgsFeedback *mFeedback = nullptr;
+    std::unique_ptr<QgsFeedback> mFeedback;
     QString mErrorString;
 };