Fix crash when closing QGIS with open layout designer windows

nyalldawson · nyalldawson · commit 43e6ee0464ab · 2019-06-07T13:36:57.000+10:00
Qt connections to a lambda ALWAYS should have a context object,
or the connection lasts forever, even after the object which
made the connection is deleted.
diff --git a/src/app/layout/qgslayoutdesignerdialog.cpp b/src/app/layout/qgslayoutdesignerdialog.cpp
@@ -966,7 +966,7 @@ void QgsLayoutDesignerDialog::setMasterLayout( QgsMasterLayoutInterface *layout
 
   QObject *obj = dynamic_cast< QObject * >( mMasterLayout );
   if ( obj )
-    connect( obj, &QObject::destroyed, [ = ]
+    connect( obj, &QObject::destroyed, this, [ = ]
   {
     this->close();
     QgsApplication::sendPostedEvents( nullptr, QEvent::DeferredDelete );

Original file line number	Diff line number	Diff line change
`@@ -966,7 +966,7 @@ void QgsLayoutDesignerDialog::setMasterLayout( QgsMasterLayoutInterface *layout`
`966`	`966`
`967`	`967`	`QObject obj = dynamic_cast< QObject >( mMasterLayout );`
`968`	`968`	`if ( obj )`
`969`		`- connect( obj, &QObject::destroyed, [ = ]`
	`969`	`+ connect( obj, &QObject::destroyed, this, [ = ]`
`970`	`970`	`{`
`971`	`971`	`this->close();`
`972`	`972`	`QgsApplication::sendPostedEvents( nullptr, QEvent::DeferredDelete );`