Merge pull request #4222 from nyalldawson/postgres_queue_218

Dynamically adjust postgres feature queue size (backport)
qgis · Mar 5, 2017 · 43e53d5 · 43e53d5
2 parents d79bb3a + 37a7a22
commit 43e53d5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/src/providers/postgres/qgspostgresfeatureiterator.cpp b/src/providers/postgres/qgspostgresfeatureiterator.cpp
@@ -22,16 +22,13 @@
 #include "qgslogger.h"
 #include "qgsmessagelog.h"
 
+#include <QElapsedTimer>
 #include <QObject>
 #include <QSettings>
 
-
-const int QgsPostgresFeatureIterator::sFeatureQueueSize = 2000;
-
-
 QgsPostgresFeatureIterator::QgsPostgresFeatureIterator( QgsPostgresFeatureSource* source, bool ownSource, const QgsFeatureRequest& request )
     : QgsAbstractFeatureIteratorFromSource<QgsPostgresFeatureSource>( source, ownSource, request )
-    , mFeatureQueueSize( sFeatureQueueSize )
+    , mFeatureQueueSize( 1 )
     , mFetched( 0 )
     , mFetchGeometry( false )
     , mExpressionCompiled( false )
@@ -227,6 +224,9 @@ bool QgsPostgresFeatureIterator::fetchFeature( QgsFeature& feature )
 
   if ( mFeatureQueue.empty() && !mLastFetch )
   {
+    QElapsedTimer timer;
+    timer.start();
+
     QString fetch = QString( "FETCH FORWARD %1 FROM %2" ).arg( mFeatureQueueSize ).arg( mCursorName );
     QgsDebugMsgLevel( QString( "fetching %1 features." ).arg( mFeatureQueueSize ), 4 );
 
@@ -262,6 +262,15 @@ bool QgsPostgresFeatureIterator::fetchFeature( QgsFeature& feature )
       } // for each row in queue
     }
     unlock();
+
+    if ( timer.elapsed() > 500 && mFeatureQueueSize > 1 )
+    {
+      mFeatureQueueSize /= 2;
+    }
+    else if ( timer.elapsed() < 50 && mFeatureQueueSize < 10000 )
+    {
+      mFeatureQueueSize *= 2;
+    }
   }
 
   if ( mFeatureQueue.empty() )

diff --git a/src/providers/postgres/qgspostgresfeatureiterator.h b/src/providers/postgres/qgspostgresfeatureiterator.h
@@ -118,8 +118,6 @@ class QgsPostgresFeatureIterator : public QgsAbstractFeatureIteratorFromSource<Q
 
     bool mIsTransactionConnection;
 
-    static const int sFeatureQueueSize;
-
   private:
     //! returns whether the iterator supports simplify geometries on provider side
     virtual bool providerCanSimplify( QgsSimplifyMethod::MethodType methodType ) const override;