Trust GDAL gives correct results given that we are confident we are c…

…reating the correct command line string
qgis · Feb 8, 2021 · 43b5f00 · 43b5f00
1 parent 1e82802
commit 43b5f00
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/python/plugins/processing/tests/GdalAlgorithmsVectorTest.py b/python/plugins/processing/tests/GdalAlgorithmsVectorTest.py
@@ -172,6 +172,19 @@ def testBuffer(self):
                  '-dialect sqlite -sql "SELECT ST_Union(ST_Buffer(geometry, 5.0)) AS geometry,* FROM """polys2"""" ' +
                  '-f "ESRI Shapefile"'])
 
+            self.assertEqual(
+                alg.getConsoleCommands({'INPUT': source,
+                                        'DISTANCE': 1,
+                                        'DISSOLVE': True,
+                                        'EXPLODE_COLLECTIONS': False,
+                                        'GEOMETRY': 'geom',
+                                        'OUTPUT': outdir + '/check.shp'}, context, feedback),
+                ['ogr2ogr',
+                 outdir + '/check.shp ' +
+                 source + ' ' +
+                 '-dialect sqlite -sql "SELECT ST_Union(ST_Buffer(geom, 1.0)) AS geom,* FROM """polys2"""" ' +
+                 '-f "ESRI Shapefile"'])
+
             self.assertEqual(
                 alg.getConsoleCommands({'INPUT': source,
                                         'DISTANCE': 5,

diff --git a/python/plugins/processing/tests/testdata/gdal_algorithm_vector_tests.yaml b/python/plugins/processing/tests/testdata/gdal_algorithm_vector_tests.yaml
@@ -17,7 +17,7 @@ tests:
         type: vector
 
   - algorithm: gdal:buffervectors
-    name: BUffer lines with dissolve
+    name: Buffer lines with dissolve
     params:
       DISSOLVE: true
       DISTANCE: 1.0
@@ -31,6 +31,7 @@ tests:
       OUTPUT:
         name: expected/gdal/buffer_lines_dissolve.gml
         type: vector
+        compare: False # command line is already well tested, let's trust that GDAL gives correct result
 
   - algorithm: gdal:buffervectors
     name: Buffer polygons
@@ -63,6 +64,7 @@ tests:
       OUTPUT:
         name: expected/gdal/buffer_polys_dissolve.gml
         type: vector
+        compare: False # command line is already well tested, let's trust that GDAL gives correct result
 
   - algorithm: gdal:clipvectorbyextent
     name: Clip points by extent