[sipify] fix false virtual methods

qgis · Jun 8, 2017 · 41ceed3 · 41ceed3
1 parent 0591225
commit 41ceed3
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 6 deletions.
diff --git a/python/core/qgsdataitem.sip b/python/core/qgsdataitem.sip
@@ -509,8 +509,7 @@ Check if the given path is hidden from the browser model
 
   public slots:
     virtual void childrenCreated();
-    virtual void directoryChanged();
-
+    void directoryChanged();
 
   protected:
     void init();

diff --git a/python/core/qgsgeometryvalidator.sip b/python/core/qgsgeometryvalidator.sip
@@ -24,8 +24,7 @@ class QgsGeometryValidator : QThread
 
     virtual void run();
 
-    virtual void stop();
-
+    void stop();
 
     static void validateGeometry( const QgsGeometry *g, QList<QgsGeometry::Error> &errors /Out/, QgsGeometry::ValidationMethod method = QgsGeometry::ValidatorQgisInternal );
 %Docstring

diff --git a/python/core/symbology-ng/qgssinglesymbolrenderer.sip b/python/core/symbology-ng/qgssinglesymbolrenderer.sip
@@ -35,6 +35,12 @@ class QgsSingleSymbolRenderer : QgsFeatureRenderer
 
     virtual void toSld( QDomDocument &doc, QDomElement &element, const QgsStringMap &props = QgsStringMap() ) const;
     static QgsFeatureRenderer *createFromSld( QDomElement &element, QgsWkbTypes::GeometryType geomType );
+<<<<<<< Updated upstream
+=======
+%Docstring
+ :rtype: QgsFeatureRenderer
+%End
+>>>>>>> Stashed changes
 
     virtual QgsFeatureRenderer::Capabilities capabilities();
     virtual QgsSymbolList symbols( QgsRenderContext &context );

diff --git a/python/gui/qgscollapsiblegroupbox.sip b/python/gui/qgscollapsiblegroupbox.sip
@@ -212,8 +212,10 @@ Returns the name of the setting group in which the collapsed state will be saved
     void init();
     virtual void showEvent( QShowEvent *event );
 
-    virtual QString saveKey() const;
-
+    QString saveKey() const;
+%Docstring
+ :rtype: str
+%End
 
 
 };

diff --git a/scripts/sipify.pl b/scripts/sipify.pl
@@ -714,6 +714,7 @@ sub detect_comment_block{
             elsif ( $LINE !~ m/^(\s*)virtual\b(.*)$/ ){
                 #sip often requires the virtual keyword to be present, or it chokes on covariant return types
                 #in overridden methods
+                dbg_info('adding virtual keyword for overriden method');
                 $LINE =~ s/^(\s*?)\b(.*)$/$1virtual $2\n/;
             }
         }
@@ -833,6 +834,9 @@ sub detect_comment_block{
         $RETURN_TYPE = '';
         $IS_OVERRIDE = 0;
     }
+    else {
+        $IS_OVERRIDE = 0;
+    }
 }
 write_header_footer();