Make composer a bit more robust against accidential mouse clicks

git-svn-id: http://svn.osgeo.org/qgis/trunk@12801 c8812cc2-4d05-0410-92ff-de0c093fc19c
qgis · Jan 20, 2010 · 40ee48c · 40ee48c
1 parent 7f6c995
commit 40ee48c
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 5 deletions.
diff --git a/src/core/composer/qgspaperitem.cpp b/src/core/composer/qgspaperitem.cpp
@@ -20,19 +20,17 @@
 
 QgsPaperItem::QgsPaperItem( QgsComposition* c ): QgsComposerItem( c, false )
 {
-  setFlag( QGraphicsItem::ItemIsSelectable, false );
-  setZValue( 0 );
+  initialize();
 }
 
 QgsPaperItem::QgsPaperItem( qreal x, qreal y, qreal width, qreal height, QgsComposition* composition ): QgsComposerItem( x, y, width, height, composition, false )
 {
-  setFlag( QGraphicsItem::ItemIsSelectable, false );
-  setZValue( 0 );
+  initialize();
 }
 
 QgsPaperItem::QgsPaperItem(): QgsComposerItem( 0, false )
 {
-
+  initialize();
 }
 
 QgsPaperItem::~QgsPaperItem()
@@ -119,3 +117,10 @@ bool QgsPaperItem::readXML( const QDomElement& itemElem, const QDomDocument& doc
 {
   return true;
 }
+
+void QgsPaperItem::initialize()
+{
+  setFlag( QGraphicsItem::ItemIsSelectable, false );
+  setFlag( QGraphicsItem::ItemIsMovable, false );
+  setZValue( 0 );
+}
diff --git a/src/core/composer/qgspaperitem.h b/src/core/composer/qgspaperitem.h
@@ -45,6 +45,8 @@ class CORE_EXPORT QgsPaperItem: public QgsComposerItem
 
   private:
     QgsPaperItem();
+    /**Set flags and z-value*/
+    void initialize();
 };
 
 #endif
diff --git a/src/gui/qgscomposerview.cpp b/src/gui/qgscomposerview.cpp
@@ -106,6 +106,7 @@ void QgsComposerView::mousePressEvent( QMouseEvent* e )
       mRubberBandLineItem->setZValue( 100 );
       scene()->addItem( mRubberBandLineItem );
       scene()->update();
+      break;
     }
 
     //create rubber band for map and ellipse items
@@ -157,13 +158,15 @@ void QgsComposerView::mousePressEvent( QMouseEvent* e )
       addComposerPicture( newPicture );
       newPicture->setSceneRect( QRectF( snappedScenePoint.x(), snappedScenePoint.y(), 30, 30 ) );
       emit actionFinished();
+      break;
     }
     case AddTable:
     {
       QgsComposerTable* newTable = new QgsComposerTable( composition() );
       addComposerTable( newTable );
       newTable->setSceneRect( QRectF( snappedScenePoint.x(), snappedScenePoint.y(), 50, 50 ) );
       emit actionFinished();
+      break;
     }
 
     default:
@@ -233,6 +236,7 @@ void QgsComposerView::mouseReleaseEvent( QMouseEvent* e )
       addComposerShape( composerShape );
       scene()->removeItem( mRubberBandItem );
       delete mRubberBandItem;
+      mRubberBandItem = 0;
       emit actionFinished();
       break;
     }
@@ -358,6 +362,11 @@ void QgsComposerView::mouseMoveEvent( QMouseEvent* e )
   }
 }
 
+void QgsComposerView::mouseDoubleClickEvent( QMouseEvent* e )
+{
+  e->ignore();
+}
+
 void QgsComposerView::keyPressEvent( QKeyEvent * e )
 {
   if ( e->key() == Qt::Key_Shift )

diff --git a/src/gui/qgscomposerview.h b/src/gui/qgscomposerview.h
@@ -102,6 +102,7 @@ class GUI_EXPORT QgsComposerView: public QGraphicsView
     void mousePressEvent( QMouseEvent* );
     void mouseReleaseEvent( QMouseEvent* );
     void mouseMoveEvent( QMouseEvent* );
+    void mouseDoubleClickEvent( QMouseEvent* e );
 
     void keyPressEvent( QKeyEvent * e );
     void keyReleaseEvent( QKeyEvent * e );