[processing] Correctly delete processing dialogs

del only delete the python variable, not the dialog which is owned by the main window.
qgis · Aug 5, 2017 · 40ccd3b · 40ccd3b
1 parent 04059eb
commit 40ccd3b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/python/plugins/processing/gui/AlgorithmLocatorFilter.py b/python/plugins/processing/gui/AlgorithmLocatorFilter.py
@@ -90,7 +90,7 @@ def triggerResult(self, result):
             dlg.exec_()
             # have to manually delete the dialog - otherwise it's owned by the
             # iface mainWindow and never deleted
-            del dlg
+            dlg.deleteLater()
             if canvas.mapTool() != prevMapTool:
                 try:
                     canvas.mapTool().reset()

diff --git a/python/plugins/processing/gui/ProcessingToolbox.py b/python/plugins/processing/gui/ProcessingToolbox.py
@@ -252,7 +252,7 @@ def executeAlgorithmAsBatchProcess(self):
                 dlg.exec_()
                 # have to manually delete the dialog - otherwise it's owned by the
                 # iface mainWindow and never deleted
-                del dlg
+                dlg.deleteLater()
 
     def executeAlgorithm(self):
         item = self.algorithmTree.currentItem()
@@ -293,7 +293,7 @@ def executeAlgorithm(self):
                         self.addRecentAlgorithms(True)
                 # have to manually delete the dialog - otherwise it's owned by the
                 # iface mainWindow and never deleted
-                del dlg
+                dlg.deleteLater()
             else:
                 feedback = MessageBarProgress()
                 context = dataobjects.createContext(feedback)

diff --git a/python/plugins/processing/gui/ScriptEditorDialog.py b/python/plugins/processing/gui/ScriptEditorDialog.py
@@ -280,7 +280,7 @@ def runAlgorithm(self):
 
         # have to manually delete the dialog - otherwise it's owned by the
         # iface mainWindow and never deleted
-        del dlg
+        dlg.deleteLater()
 
         if canvas.mapTool() != prevMapTool:
             try:

diff --git a/python/plugins/processing/modeler/ModelerDialog.py b/python/plugins/processing/modeler/ModelerDialog.py
@@ -293,7 +293,7 @@ def runModel(self):
         dlg.exec_()
         # have to manually delete the dialog - otherwise it's owned by the
         # iface mainWindow and never deleted
-        del dlg
+        dlg.deleteLater()
 
     def save(self):
         self.saveModel(False)