Skip to content

Commit

Permalink
[ui] rename the min/max widget group box title
Browse files Browse the repository at this point in the history
Since there is no more loading involved through
the min/max widget, rename it to:
"Min /max values settings"
  • Loading branch information
nirvn committed Dec 27, 2016
1 parent 578e9b8 commit 407991e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ui/qgsrasterminmaxwidgetbase.ui
Expand Up @@ -29,7 +29,7 @@
<item>
<widget class="QgsCollapsibleGroupBox" name="mLoadMinMaxValuesGroupBox">
<property name="title">
<string>Load min/max values</string>
<string>Min / max values settings</string>
</property>
<property name="flat">
<bool>true</bool>
Expand Down

4 comments on commit 407991e

@nirvn
Copy link
Contributor Author

@nirvn nirvn commented on 407991e Dec 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rouault , I was wondering whether the "Updated canvas" label was a bit obscure for the newcomers. Do you think "Dynamic canvas" could a better naming for the function? IMHO it does a better job at reflecting what it does.

@rouault
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't satisfied with the Updated canvas label either. I think I also considered Refreshed canvas. But dynamic sounds better

@nirvn
Copy link
Contributor Author

@nirvn nirvn commented on 407991e Dec 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rouault , do you feel like doing the bit of renaming required (i.e. the QgsRasterMinMaxOrigin::UpdatedCanvas, etc.)? If not, I can commit to it.

@nirvn
Copy link
Contributor Author

@nirvn nirvn commented on 407991e Dec 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rouault , an extra bonus to "Dynamic canvas", it'll help people leaving ArcGIS behind to link that with ESRI's equivalent (if memory serves well, it's called dynamic range adjustment).

Please sign in to comment.