Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Make QgsSymbolLayerUtils::symbolPreview* methods const, and utilise
internal symbol clones Rendering symbols is a NON-CONST operation, which can permanently alter the symbol instance (e.g. via changes made by the symbol or symbol layer's startRender methods.). This makes debugging super complex - because methods which look like they are just generating previews of symbols can actually change the original symbol instances, resulting in permanent changes to a layer's style. Refs #19910 (specifically, me pulling my hair out trying to deduce seemingly random changes to layer's symbols)
- Loading branch information
1 parent
431861a
commit 4022c5f
Showing
5 changed files
with
22 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters