Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Remove some redundant geos includes
  • Loading branch information
nyalldawson committed Apr 26, 2018
1 parent d5626d9 commit 3f6e411
Show file tree
Hide file tree
Showing 36 changed files with 0 additions and 36 deletions.
1 change: 0 additions & 1 deletion python/CMakeLists.txt
Expand Up @@ -86,7 +86,6 @@ INCLUDE_DIRECTORIES(SYSTEM
${QT_QTSVG_INCLUDE_DIR}
${QT_QTXML_INCLUDE_DIR}
${GDAL_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QWT_INCLUDE_DIR}
${QEXTSERIALPORT_INCLUDE_DIR}
${QCA_INCLUDE_DIR}
Expand Down
1 change: 0 additions & 1 deletion src/3d/CMakeLists.txt
Expand Up @@ -133,7 +133,6 @@ INCLUDE_DIRECTORIES(
)
INCLUDE_DIRECTORIES(SYSTEM
${PROJ_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${GDAL_INCLUDE_DIR}
${SQLITE3_INCLUDE_DIR}
)
Expand Down
1 change: 0 additions & 1 deletion src/analysis/CMakeLists.txt
Expand Up @@ -276,7 +276,6 @@ INCLUDE_DIRECTORIES(
INCLUDE_DIRECTORIES(SYSTEM
${SPATIALINDEX_INCLUDE_DIR} # before GEOS for case-insensitive filesystems
${PROJ_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${GDAL_INCLUDE_DIR}
${SQLITE3_INCLUDE_DIR}
)
Expand Down
1 change: 0 additions & 1 deletion src/gui/CMakeLists.txt
Expand Up @@ -911,7 +911,6 @@ INCLUDE_DIRECTORIES(SYSTEM
${QWT_INCLUDE_DIR}
${SQLITE3_INCLUDE_DIR}
${QSCINTILLA_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${GDAL_INCLUDE_DIR}
)

Expand Down
1 change: 0 additions & 1 deletion src/plugins/coordinate_capture/CMakeLists.txt
Expand Up @@ -41,7 +41,6 @@ INCLUDE_DIRECTORIES(
${CMAKE_BINARY_DIR}/src/ui
)
INCLUDE_DIRECTORIES(SYSTEM
${GEOS_INCLUDE_DIR}
)

TARGET_LINK_LIBRARIES(coordinatecaptureplugin
Expand Down
1 change: 0 additions & 1 deletion src/plugins/evis/CMakeLists.txt
Expand Up @@ -50,7 +50,6 @@ ADD_LIBRARY (evis MODULE ${evis_SRCS} ${evis_MOC_SRCS} ${evis_RCC_SRCS} ${evis_U

INCLUDE_DIRECTORIES(SYSTEM
${GDAL_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QT_INCLUDE_DIR}
)
INCLUDE_DIRECTORIES(
Expand Down
1 change: 0 additions & 1 deletion src/plugins/geometry_checker/CMakeLists.txt
Expand Up @@ -65,7 +65,6 @@ INCLUDE_DIRECTORIES(
${CMAKE_CURRENT_SOURCE_DIR}
)
INCLUDE_DIRECTORIES(SYSTEM
${GEOS_INCLUDE_DIR}
${GDAL_INCLUDE_DIR}
)

Expand Down
1 change: 0 additions & 1 deletion src/plugins/georeferencer/CMakeLists.txt
Expand Up @@ -97,7 +97,6 @@ INCLUDE_DIRECTORIES(SYSTEM
${GSL_INCLUDE_DIR}
${QGIS_INCLUDE_DIR}
${GDAL_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QT_QTXML_INCLUDE_DIR}
${QWT_INCLUDE_DIR}
)
Expand Down
1 change: 0 additions & 1 deletion src/plugins/gps_importer/CMakeLists.txt
Expand Up @@ -51,7 +51,6 @@ INCLUDE_DIRECTORIES(SYSTEM
${EXPAT_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
${QEXTSERIALPORT_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
)

TARGET_LINK_LIBRARIES(gpsimporterplugin
Expand Down
1 change: 0 additions & 1 deletion src/plugins/offline_editing/CMakeLists.txt
Expand Up @@ -46,7 +46,6 @@ TARGET_LINK_LIBRARIES(offlineeditingplugin
INCLUDE_DIRECTORIES(SYSTEM
${SPATIALITE_INCLUDE_DIR}
${SQLITE3_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
)

INCLUDE_DIRECTORIES(
Expand Down
1 change: 0 additions & 1 deletion src/providers/arcgisrest/CMakeLists.txt
Expand Up @@ -14,7 +14,6 @@ INCLUDE_DIRECTORIES(
)

INCLUDE_DIRECTORIES(SYSTEM
${GEOS_INCLUDE_DIR}
)

IF (WITH_GUI)
Expand Down
1 change: 0 additions & 1 deletion src/providers/db2/CMakeLists.txt
Expand Up @@ -48,7 +48,6 @@ INCLUDE_DIRECTORIES(
)

INCLUDE_DIRECTORIES(SYSTEM
${GEOS_INCLUDE_DIR}
${QT_INCLUDE_DIR}
)

Expand Down
1 change: 0 additions & 1 deletion src/providers/delimitedtext/CMakeLists.txt
Expand Up @@ -37,7 +37,6 @@ INCLUDE_DIRECTORIES(
${CMAKE_BINARY_DIR}/src/ui
)
INCLUDE_DIRECTORIES (SYSTEM
${GEOS_INCLUDE_DIR}
)

QT5_WRAP_CPP(DTEXT_MOC_SRCS ${DTEXT_MOC_HDRS})
Expand Down
1 change: 0 additions & 1 deletion src/providers/gdal/CMakeLists.txt
Expand Up @@ -35,7 +35,6 @@ INCLUDE_DIRECTORIES (
)
INCLUDE_DIRECTORIES (SYSTEM
${GDAL_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QTKEYCHAIN_INCLUDE_DIR}
${QCA_INCLUDE_DIR}
)
Expand Down
1 change: 0 additions & 1 deletion src/providers/geonode/CMakeLists.txt
Expand Up @@ -41,7 +41,6 @@ INCLUDE_DIRECTORIES(
${CMAKE_BINARY_DIR}/src/ui
)
INCLUDE_DIRECTORIES(SYSTEM
${GEOS_INCLUDE_DIR}
)

ADD_LIBRARY(geonodeprovider MODULE ${GEONODE_SRCS} ${GEONODE_MOC_SRCS})
Expand Down
1 change: 0 additions & 1 deletion src/providers/gpx/CMakeLists.txt
Expand Up @@ -25,7 +25,6 @@ INCLUDE_DIRECTORIES(
${CMAKE_BINARY_DIR}/src/gui
)
INCLUDE_DIRECTORIES (SYSTEM
${GEOS_INCLUDE_DIR}
${EXPAT_INCLUDE_DIR}
)

Expand Down
1 change: 0 additions & 1 deletion src/providers/grass/CMakeLists.txt
Expand Up @@ -18,7 +18,6 @@ INCLUDE_DIRECTORIES(
INCLUDE_DIRECTORIES (SYSTEM
${GDAL_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${POSTGRES_INCLUDE_DIR}
)

Expand Down
1 change: 0 additions & 1 deletion src/providers/mssql/CMakeLists.txt
Expand Up @@ -48,7 +48,6 @@ INCLUDE_DIRECTORIES(
)
INCLUDE_DIRECTORIES(SYSTEM
${GDAL_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QT_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
)
Expand Down
1 change: 0 additions & 1 deletion src/providers/ogr/CMakeLists.txt
Expand Up @@ -54,7 +54,6 @@ INCLUDE_DIRECTORIES(
)
INCLUDE_DIRECTORIES(SYSTEM
${GDAL_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QTKEYCHAIN_INCLUDE_DIR}
${QCA_INCLUDE_DIR}
${QSCINTILLA_INCLUDE_DIR}
Expand Down
1 change: 0 additions & 1 deletion src/providers/ows/CMakeLists.txt
Expand Up @@ -22,7 +22,6 @@ INCLUDE_DIRECTORIES (
)
INCLUDE_DIRECTORIES(SYSTEM
${PROJ_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
)

QT5_WRAP_CPP(OWS_MOC_SRCS ${OWS_MOC_HDRS})
Expand Down
1 change: 0 additions & 1 deletion src/providers/postgres/CMakeLists.txt
Expand Up @@ -64,7 +64,6 @@ INCLUDE_DIRECTORIES(

INCLUDE_DIRECTORIES(SYSTEM
${POSTGRES_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QCA_INCLUDE_DIR}
${QTKEYCHAIN_INCLUDE_DIR}
)
Expand Down
1 change: 0 additions & 1 deletion src/providers/spatialite/CMakeLists.txt
Expand Up @@ -57,7 +57,6 @@ INCLUDE_DIRECTORIES(
INCLUDE_DIRECTORIES(SYSTEM
${SQLITE3_INCLUDE_DIR}
${SPATIALITE_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
)

ADD_LIBRARY (spatialiteprovider MODULE ${SPATIALITE_SRCS} ${SPATIALITE_MOC_SRCS})
Expand Down
1 change: 0 additions & 1 deletion src/providers/virtual/CMakeLists.txt
Expand Up @@ -55,7 +55,6 @@ INCLUDE_DIRECTORIES(SYSTEM
${POSTGRES_INCLUDE_DIR}
${SQLITE3_INCLUDE_DIR}
${SPATIALITE_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QCA_INCLUDE_DIR}
)

Expand Down
1 change: 0 additions & 1 deletion src/providers/wcs/CMakeLists.txt
Expand Up @@ -42,7 +42,6 @@ INCLUDE_DIRECTORIES(SYSTEM
${GDAL_INCLUDE_DIR}
${QCA_INCLUDE_DIR}
${QTKEYCHAIN_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
)

ADD_LIBRARY(wcsprovider MODULE ${WCS_SRCS} ${WCS_MOC_SRCS})
Expand Down
1 change: 0 additions & 1 deletion src/providers/wfs/CMakeLists.txt
Expand Up @@ -60,7 +60,6 @@ INCLUDE_DIRECTORIES (
${CMAKE_BINARY_DIR}/src/ui
)
INCLUDE_DIRECTORIES(SYSTEM
${GEOS_INCLUDE_DIR}
${EXPAT_INCLUDE_DIR}
${QCA_INCLUDE_DIR}
${QTKEYCHAIN_INCLUDE_DIR}
Expand Down
1 change: 0 additions & 1 deletion src/providers/wms/CMakeLists.txt
Expand Up @@ -49,7 +49,6 @@ INCLUDE_DIRECTORIES(
)
INCLUDE_DIRECTORIES(SYSTEM
${GDAL_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QCA_INCLUDE_DIR}
${QTKEYCHAIN_INCLUDE_DIR}
)
Expand Down
1 change: 0 additions & 1 deletion src/server/CMakeLists.txt
Expand Up @@ -86,7 +86,6 @@ ENDIF(MSVC)
INCLUDE_DIRECTORIES(SYSTEM
${GDAL_INCLUDE_DIR}
${FCGI_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
${POSTGRES_INCLUDE_DIR}
)
Expand Down
1 change: 0 additions & 1 deletion src/server/services/wcs/CMakeLists.txt
Expand Up @@ -18,7 +18,6 @@ ADD_LIBRARY (wcs MODULE ${wcs_SRCS})

INCLUDE_DIRECTORIES(SYSTEM
${GDAL_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
${POSTGRES_INCLUDE_DIR}
)
Expand Down
1 change: 0 additions & 1 deletion src/server/services/wfs/CMakeLists.txt
Expand Up @@ -28,7 +28,6 @@ ADD_LIBRARY (wfs MODULE ${wfs_SRCS} ${wfs_MOC_SRCS} ${wfs_MOC_HDRS})

INCLUDE_DIRECTORIES(SYSTEM
${GDAL_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
${POSTGRES_INCLUDE_DIR}
)
Expand Down
1 change: 0 additions & 1 deletion src/server/services/wms/CMakeLists.txt
Expand Up @@ -36,7 +36,6 @@ ADD_LIBRARY (wms MODULE ${wms_SRCS} ${wms_MOC_SRCS} ${wms_MOC_HDRS})

INCLUDE_DIRECTORIES(SYSTEM
${GDAL_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
${POSTGRES_INCLUDE_DIR}
)
Expand Down
1 change: 0 additions & 1 deletion tests/bench/CMakeLists.txt
Expand Up @@ -28,7 +28,6 @@ INCLUDE_DIRECTORIES(
${CMAKE_BINARY_DIR}/src/core
)
INCLUDE_DIRECTORIES(SYSTEM
${GEOS_INCLUDE_DIR}
${SQLITE3_INCLUDE_DIR}
)

Expand Down
1 change: 0 additions & 1 deletion tests/src/3d/CMakeLists.txt
Expand Up @@ -33,7 +33,6 @@ INCLUDE_DIRECTORIES(SYSTEM
${QT_INCLUDE_DIR}
${GDAL_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
)

#note for tests we should not include the moc of our
Expand Down
1 change: 0 additions & 1 deletion tests/src/geometry_checker/CMakeLists.txt
Expand Up @@ -20,7 +20,6 @@ INCLUDE_DIRECTORIES(SYSTEM
${QT_INCLUDE_DIR}
${GDAL_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QCA_INCLUDE_DIR}
${QTKEYCHAIN_INCLUDE_DIR}
${POSTGRES_INCLUDE_DIR}
Expand Down
1 change: 0 additions & 1 deletion tests/src/gui/CMakeLists.txt
Expand Up @@ -39,7 +39,6 @@ INCLUDE_DIRECTORIES(SYSTEM
${QT_INCLUDE_DIR}
${GDAL_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QWT_INCLUDE_DIR}
${QCA_INCLUDE_DIR}
${QTKEYCHAIN_INCLUDE_DIR}
Expand Down
1 change: 0 additions & 1 deletion tests/src/providers/CMakeLists.txt
Expand Up @@ -22,7 +22,6 @@ INCLUDE_DIRECTORIES(SYSTEM
${QT_INCLUDE_DIR}
${GDAL_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QCA_INCLUDE_DIR}
${QTKEYCHAIN_INCLUDE_DIR}
${POSTGRES_INCLUDE_DIR}
Expand Down
1 change: 0 additions & 1 deletion tests/src/providers/grass/CMakeLists.txt
Expand Up @@ -4,7 +4,6 @@ INCLUDE_DIRECTORIES(
INCLUDE_DIRECTORIES(SYSTEM
${GDAL_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${POSTGRES_INCLUDE_DIR}
)

Expand Down

1 comment on commit 3f6e411

@telwertowski
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS needs GEOS for python, src/analysis, src/plugins/geometry_checker and src/providers/grass

In file included from /Users/tce/Developer/qgis/build/python/core/qgslabelsearchtree.sip:20:
In file included from /Users/tce/Developer/qgis/QGIS/src/core/qgslabelsearchtree.h:26:
/Users/tce/Developer/qgis/QGIS/src/core/pal/pointset.h:39:10: fatal error: 
      'geos_c.h' file not found
#include <geos_c.h>

In file included from /Users/tce/Developer/qgis/QGIS/src/analysis/vector/geometry_checker/qgsgeometrychecker.cpp:18:
/Users/tce/Developer/qgis/QGIS/src/analysis/vector/geometry_checker/qgsgeometrycheck.h:29:10: fatal error: 
      'geos_c.h' file not found
#include "geos_c.h"

In file included from /Users/tce/Developer/qgis/QGIS/src/plugins/geometry_checker/qgsgeometrycheckersetuptab.cpp:22:
/Users/tce/Developer/qgis/QGIS/src/analysis/vector/geometry_checker/qgsgeometrycheck.h:29:10: fatal error: 
      'geos_c.h' file not found
#include "geos_c.h"

In file included from /Users/tce/Developer/qgis/QGIS/src/providers/grass/qgsgrass.cpp:69:
/Users/tce/Developer/packages/grass-7.4.0/dist.x86_64-apple-darwin17.4.0/include/grass/vector.h:7:10: fatal error: 
      'geos_c.h' file not found
#include <geos_c.h>

Please sign in to comment.