Skip to content

Commit 3e67ad5

Browse files
committedMay 24, 2018
[oracle] Some updates to Oracle provider test suite
Now the Oracle provider passes the data provider edit stress/ conformance tests without issue! (cherry-picked from 68838aa)
1 parent 32ba752 commit 3e67ad5

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed
 

‎tests/src/python/test_provider_oracle.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def execSQLCommand(self, sql, ignore_errors=False):
6464
query.finish()
6565

6666
# disabled: WIP
67-
def disabled_getSource(self):
67+
def getSource(self):
6868
# create temporary table for edit tests
6969
self.execSQLCommand('DROP TABLE "QGIS"."EDIT_DATA"', ignore_errors=True)
7070
self.execSQLCommand("""CREATE TABLE QGIS.EDIT_DATA ("pk" INTEGER GENERATED by default ON null as IDENTITY(START WITH 1 INCREMENT BY 1) PRIMARY KEY, "cnt" INTEGER, "name" VARCHAR2(100), "name2" VARCHAR2(100), "num_char" VARCHAR2(100), GEOM SDO_GEOMETRY)""")
@@ -80,7 +80,7 @@ def disabled_getSource(self):
8080
return vl
8181

8282
# disabled: WIP
83-
def disabled_getEditableLayer(self):
83+
def getEditableLayer(self):
8484
return self.getSource()
8585

8686
def enableCompiler(self):
@@ -110,6 +110,13 @@ def uncompiledFilters(self):
110110
'intersects($geometry,geom_from_wkt( \'Polygon ((-72.2 66.1, -65.2 66.1, -65.2 72.0, -72.2 72.0, -72.2 66.1))\'))'])
111111
return filters
112112

113+
def testAddFeatureWrongGeomType(self):
114+
"""
115+
We override this test for Oracle provider, because Oracle DBs don't care
116+
about geometry type constraints
117+
"""
118+
pass
119+
113120
# HERE GO THE PROVIDER SPECIFIC TESTS
114121
def testDateTimeTypes(self):
115122
vl = QgsVectorLayer('%s table="QGIS"."DATE_TIMES" sql=' %

0 commit comments

Comments
 (0)
Please sign in to comment.