Extra simple fast check of types in equality methods of geometry

qgis · Dec 5, 2019 · 3dadc22 · 3dadc22
1 parent d182cf2
commit 3dadc22
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/core/geometry/qgsgeometry.cpp b/src/core/geometry/qgsgeometry.cpp
@@ -1230,6 +1230,10 @@ bool QgsGeometry::equals( const QgsGeometry &geometry ) const
   if ( d == geometry.d )
     return true;
 
+  // fast check - distinct geometry types?
+  if ( type() != geometry.type() )
+    return false;
+
   // slower check - actually test the geometries
   return *d->geometry == *geometry.d->geometry;
 }
@@ -2604,6 +2608,10 @@ bool QgsGeometry::isGeosEqual( const QgsGeometry &g ) const
   if ( d == g.d )
     return true;
 
+  // fast check - distinct geometry types?
+  if ( type() != g.type() )
+    return false;
+
   // avoid calling geos for trivial point case
   if ( QgsWkbTypes::flatType( d->geometry->wkbType() ) == QgsWkbTypes::Point
        && QgsWkbTypes::flatType( g.d->geometry->wkbType() ) == QgsWkbTypes::Point )