Avoid extra copy of point in QgsGeometry::centroid()

qgis · Aug 13, 2017 · 3da4c33 · 3da4c33
1 parent 7f4880b
commit 3da4c33
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/core/geometry/qgsgeometry.cpp b/src/core/geometry/qgsgeometry.cpp
@@ -1585,16 +1585,16 @@ QgsGeometry QgsGeometry::centroid() const
   }
 
   QgsGeos geos( d->geometry );
-  QgsPoint centroid;
+  std::unique_ptr<QgsPoint> centroid( new QgsPoint() );
   QString error;
-  bool ok = geos.centroid( centroid, &error );
+  bool ok = geos.centroid( *centroid.get(), &error );
   if ( !ok )
   {
     QgsGeometry geom;
     geom.d->error = error;
     return geom;
   }
-  return QgsGeometry( centroid.clone() );
+  return QgsGeometry( centroid.release() );
 }
 
 QgsGeometry QgsGeometry::pointOnSurface() const