[editwidgets] text color for r/o line edits matches disabled color

m-kuhn · m-kuhn · commit 3d9ba705de98 · 2014-10-15T16:23:20.000+02:00
Line edits are set to readonly to make it possible to copy values from disabled forms. Unfortunately Qt uses a style that makes them look editable even though they are not. This patches the text color to have the appearance that hints an uneditable widget. Fix #11413
diff --git a/src/gui/editorwidgets/qgstexteditwrapper.cpp b/src/gui/editorwidgets/qgstexteditwrapper.cpp
@@ -105,6 +105,10 @@ void QgsTextEditWrapper::initWidget( QWidget* editor )
     }
 
     connect( mLineEdit, SIGNAL( textChanged( QString ) ), this, SLOT( valueChanged( QString ) ) );
+
+    mWritablePalette = mLineEdit->palette();
+    mReadOnlyPalette = mLineEdit->palette();
+    mReadOnlyPalette.setColor( QPalette::Text, mWritablePalette.color( QPalette::Disabled, QPalette::Text ) );
   }
 }
 
@@ -143,5 +147,11 @@ void QgsTextEditWrapper::setEnabled( bool enabled )
     mPlainTextEdit->setReadOnly( !enabled );
 
   if ( mLineEdit )
+  {
     mLineEdit->setReadOnly( !enabled );
+    if ( enabled )
+      mLineEdit->setPalette( mWritablePalette );
+    else
+      mLineEdit->setPalette( mReadOnlyPalette );
+  }
 }
diff --git a/src/gui/editorwidgets/qgstexteditwrapper.h b/src/gui/editorwidgets/qgstexteditwrapper.h
@@ -55,6 +55,8 @@ class GUI_EXPORT QgsTextEditWrapper : public QgsEditorWidgetWrapper
     QTextEdit* mTextEdit;
     QPlainTextEdit* mPlainTextEdit;
     QLineEdit* mLineEdit;
+    QPalette mReadOnlyPalette;
+    QPalette mWritablePalette;
 };
 
 #endif // QGSTEXTEDITWRAPPER_H

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,10 @@ void QgsTextEditWrapper::initWidget( QWidget* editor )`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`connect( mLineEdit, SIGNAL( textChanged( QString ) ), this, SLOT( valueChanged( QString ) ) );`
	`108`	`+`
	`109`	`+ mWritablePalette = mLineEdit->palette();`
	`110`	`+ mReadOnlyPalette = mLineEdit->palette();`
	`111`	`+ mReadOnlyPalette.setColor( QPalette::Text, mWritablePalette.color( QPalette::Disabled, QPalette::Text ) );`
`108`	`112`	`}`
`109`	`113`	`}`
`110`	`114`
`@@ -143,5 +147,11 @@ void QgsTextEditWrapper::setEnabled( bool enabled )`
`143`	`147`	`mPlainTextEdit->setReadOnly( !enabled );`
`144`	`148`
`145`	`149`	`if ( mLineEdit )`
	`150`	`+ {`
`146`	`151`	`mLineEdit->setReadOnly( !enabled );`
	`152`	`+ if ( enabled )`
	`153`	`+ mLineEdit->setPalette( mWritablePalette );`
	`154`	`+ else`
	`155`	`+ mLineEdit->setPalette( mReadOnlyPalette );`
	`156`	`+ }`
`147`	`157`	`}`