Fix false positive cppcheck pureVirtualCall warnings when pure

nyalldawson · nyalldawson · commit 3c64bcc6a677 · 2023-04-17T16:29:44.000+10:00
virtual functions are called as slots
diff --git a/python/gui/auto_generated/processing/models/qgsmodeldesignerdialog.sip.in b/python/gui/auto_generated/processing/models/qgsmodeldesignerdialog.sip.in
@@ -84,10 +84,14 @@ Raise, unminimize and activate this window.
 
   protected:
 
+
     virtual void repaintModel( bool showControls = true ) = 0;
     virtual void addAlgorithm( const QString &algorithmId, const QPointF &pos ) = 0;
+
     virtual void addInput( const QString &inputId, const QPointF &pos ) = 0;
+
     virtual void exportAsScriptAlgorithm() = 0;
+
     virtual bool saveModel( bool saveAs = false ) = 0;
 
     QToolBar *toolbar();
diff --git a/src/core/gps/qgsgpsconnection.h b/src/core/gps/qgsgpsconnection.h
@@ -193,7 +193,7 @@ class CORE_EXPORT QgsGpsConnection : public QObject
 
   protected slots:
     //! Parse available data source content
-    virtual void parseData() = 0;
+    virtual void parseData() = 0;  // cppcheck-suppress pureVirtualCall
 
   private:
 
diff --git a/src/gui/processing/models/qgsmodeldesignerdialog.h b/src/gui/processing/models/qgsmodeldesignerdialog.h
@@ -120,7 +120,9 @@ class GUI_EXPORT QgsModelDesignerDialog : public QMainWindow, public Ui::QgsMode
     // cppcheck-suppress pureVirtualCall
     virtual void repaintModel( bool showControls = true ) = 0;
     virtual void addAlgorithm( const QString &algorithmId, const QPointF &pos ) = 0;
+    // cppcheck-suppress pureVirtualCall
     virtual void addInput( const QString &inputId, const QPointF &pos ) = 0;
+    // cppcheck-suppress pureVirtualCall
     virtual void exportAsScriptAlgorithm() = 0;
     // cppcheck-suppress pureVirtualCall
     virtual bool saveModel( bool saveAs = false ) = 0;
diff --git a/src/gui/processing/qgsprocessingbatchalgorithmdialogbase.h b/src/gui/processing/qgsprocessingbatchalgorithmdialogbase.h
@@ -54,7 +54,7 @@ class GUI_EXPORT QgsProcessingBatchAlgorithmDialogBase : public QgsProcessingAlg
     /**
      * Will be called when the "Run as Single" button is clicked.
      */
-    virtual void runAsSingle() = 0;
+    virtual void runAsSingle() = 0; // cppcheck-suppress pureVirtualCall
 
   protected slots:
 
diff --git a/src/gui/qgsfilecontentsourcelineedit.h b/src/gui/qgsfilecontentsourcelineedit.h
@@ -111,37 +111,37 @@ class GUI_EXPORT QgsAbstractFileContentSourceLineEdit : public QWidget SIP_ABSTR
     /**
      * Returns the widget's file filter string.
      */
-    virtual QString fileFilter() const = 0;
+    virtual QString fileFilter() const = 0;  // cppcheck-suppress pureVirtualCall
 
     /**
      * Returns the translated title to use for the select file dialog.
      */
-    virtual QString selectFileTitle() const = 0;
+    virtual QString selectFileTitle() const = 0;  // cppcheck-suppress pureVirtualCall
 
     /**
      * Returns the translated title to use for the file from URL dialog.
      */
-    virtual QString fileFromUrlTitle() const = 0;
+    virtual QString fileFromUrlTitle() const = 0;  // cppcheck-suppress pureVirtualCall
 
     /**
      * Returns the translated descriptive text to use for the file from URL dialog.
      */
-    virtual QString fileFromUrlText() const = 0;
+    virtual QString fileFromUrlText() const = 0;  // cppcheck-suppress pureVirtualCall
 
     /**
      * Returns the translated title to use for the embed file dialog.
      */
-    virtual QString embedFileTitle() const = 0;
+    virtual QString embedFileTitle() const = 0;  // cppcheck-suppress pureVirtualCall
 
     /**
      * Returns the translated title to use for the extract file dialog.
      */
-    virtual QString extractFileTitle() const = 0;
+    virtual QString extractFileTitle() const = 0;  // cppcheck-suppress pureVirtualCall
 
     /**
      * Returns the default settings key to use for the widget's settings.
      */
-    virtual QString defaultSettingsKey() const = 0;
+    virtual QString defaultSettingsKey() const = 0;  // cppcheck-suppress pureVirtualCall
 
 ///@endcond
 #endif
