[processing][gdal] Don't insert 'temporary file' strings in command f…

…or non-specified optional outputs (cherry picked from commit 0a64364)
qgis · Feb 27, 2021 · 3bf2591 · 3bf2591
1 parent 55b8cea
commit 3bf2591
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/python/plugins/processing/algs/gdal/GdalAlgorithmDialog.py b/python/plugins/processing/algs/gdal/GdalAlgorithmDialog.py
@@ -123,13 +123,16 @@ def parametersHaveChanged(self):
             parameters = self.dialog.createProcessingParameters()
             for output in self.algorithm().destinationParameterDefinitions():
                 if not output.name() in parameters or parameters[output.name()] is None:
-                    parameters[output.name()] = self.tr("[temporary file]")
+                    if not output.flags() & QgsProcessingParameterDefinition.FlagOptional:
+                        parameters[output.name()] = self.tr("[temporary file]")
             for p in self.algorithm().parameterDefinitions():
                 if p.flags() & QgsProcessingParameterDefinition.FlagHidden:
                     continue
 
-                if (not p.name() in parameters and not p.flags() & QgsProcessingParameterDefinition.FlagOptional) \
-                        or (not p.checkValueIsAcceptable(parameters[p.name()])):
+                if p.flags() & QgsProcessingParameterDefinition.FlagOptional and p.name() not in parameters:
+                    continue
+
+                if p.name() not in parameters or not p.checkValueIsAcceptable(parameters[p.name()]):
                     # not ready yet
                     self.text.setPlainText('')
                     return