Fix crash in metadata widget when remove is clicked and no items exist

nyalldawson · nyalldawson · commit 3b2334424efa · 2019-01-15T15:47:48.000+11:00
Fixes #20943 (cherry picked from commit 3bc06e2)
diff --git a/src/gui/qgsmetadatawidget.cpp b/src/gui/qgsmetadatawidget.cpp
@@ -295,6 +295,8 @@ void QgsMetadataWidget::addConstraint()
 void QgsMetadataWidget::removeSelectedConstraint()
 {
   const QModelIndexList selectedRows = tabConstraints->selectionModel()->selectedRows();
+  if ( selectedRows.empty() )
+    return;
   mConstraintsModel->removeRow( selectedRows[0].row() );
 }
 
@@ -394,6 +396,9 @@ void QgsMetadataWidget::addLink()
 void QgsMetadataWidget::removeSelectedLink()
 {
   const QModelIndexList selectedRows = tabLinks->selectionModel()->selectedRows();
+  if ( selectedRows.empty() )
+    return;
+
   mLinksModel->removeRow( selectedRows[0].row() );
 }
 

Original file line number	Diff line number	Diff line change
`@@ -295,6 +295,8 @@ void QgsMetadataWidget::addConstraint()`
`295`	`295`	`void QgsMetadataWidget::removeSelectedConstraint()`
`296`	`296`	`{`
`297`	`297`	`const QModelIndexList selectedRows = tabConstraints->selectionModel()->selectedRows();`
	`298`	`+ if ( selectedRows.empty() )`
	`299`	`+ return;`
`298`	`300`	`mConstraintsModel->removeRow( selectedRows[0].row() );`
`299`	`301`	`}`
`300`	`302`
`@@ -394,6 +396,9 @@ void QgsMetadataWidget::addLink()`
`394`	`396`	`void QgsMetadataWidget::removeSelectedLink()`
`395`	`397`	`{`
`396`	`398`	`const QModelIndexList selectedRows = tabLinks->selectionModel()->selectedRows();`
	`399`	`+ if ( selectedRows.empty() )`
	`400`	`+ return;`
	`401`	`+`
`397`	`402`	`mLinksModel->removeRow( selectedRows[0].row() );`
`398`	`403`	`}`
`399`	`404`