rebuild statistics drop-down menu only when field type changed

qgis · May 5, 2017 · 391cb73 · 391cb73
1 parent 68872e5
commit 391cb73
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/app/qgsstatisticalsummarydockwidget.cpp b/src/app/qgsstatisticalsummarydockwidget.cpp
@@ -97,6 +97,7 @@ QgsStatisticalSummaryDockWidget::QgsStatisticalSummaryDockWidget( QWidget *paren
   mOptionsToolButton->setMenu( mStatisticsMenu );
 
   mFieldType = DataType::Numeric;
+  mPreviousFieldType = DataType::Numeric;
   refreshStatisticsMenu();
 }
 
@@ -120,7 +121,11 @@ void QgsStatisticalSummaryDockWidget::refreshStatistics()
     mFieldType = fieldType( mFieldExpressionWidget->currentField() );
   }
 
-  refreshStatisticsMenu();
+  if ( mFieldType != mPreviousFieldType )
+  {
+    refreshStatisticsMenu();
+    mPreviousFieldType = mFieldType;
+  }
 
   bool selectedOnly = mSelectedOnlyCheckBox->isChecked();
 

diff --git a/src/app/qgsstatisticalsummarydockwidget.h b/src/app/qgsstatisticalsummarydockwidget.h
@@ -89,6 +89,7 @@ class APP_EXPORT QgsStatisticalSummaryDockWidget : public QgsDockWidget, private
 
     QMenu *mStatisticsMenu = nullptr;
     DataType mFieldType;
+    DataType mPreviousFieldType;
 };
 
 #endif // QGSSTATISTICALSUMMARYDOCKWIDGET_H