Don't allow removal of model parameters on which other parameters

nyalldawson · nyalldawson · commit 37cc8fc5f162 · 2017-07-03T11:02:45.000+10:00
depend
diff --git a/python/plugins/processing/modeler/ModelerGraphicItem.py b/python/plugins/processing/modeler/ModelerGraphicItem.py
@@ -229,8 +229,12 @@ def updateAlgorithm(self, alg):
     def removeElement(self):
         if isinstance(self.element, QgsProcessingModelAlgorithm.ModelParameter):
             if self.model.childAlgorithmsDependOnParameter(self.element.parameterName()):
-                QMessageBox.warning(None, 'Could not remove element',
-                                    'Other elements depend on the selected one.\n'
+                QMessageBox.warning(None, 'Could not remove input',
+                                    'Algorithms depend on the selected input.\n'
+                                    'Remove them before trying to remove it.')
+            elif self.model.otherParametersDependOnParameter(self.element.parameterName()):
+                QMessageBox.warning(None, 'Could not remove input',
+                                    'Other inputs depend on the selected input.\n'
                                     'Remove them before trying to remove it.')
             else:
                 self.model.removeModelParameter(self.element.parameterName())
