Avoid unnecessary calculations in SVG fill symbol cloning

nyalldawson · nyalldawson · commit 373190d59d9b · 2019-05-14T04:06:38.000Z
Minor speed boost
diff --git a/src/core/symbology/qgsfillsymbollayer.cpp b/src/core/symbology/qgsfillsymbollayer.cpp
@@ -1722,11 +1722,10 @@ QgsSVGFillSymbolLayer::QgsSVGFillSymbolLayer( const QString &svgFilePath, double
   : QgsImageFillSymbolLayer()
   , mPatternWidth( width )
 {
-  setSvgFilePath( svgFilePath );
   mStrokeWidth = 0.3;
   mAngle = angle;
   mColor = QColor( 255, 255, 255 );
-  setDefaultSvgParams();
+  setSvgFilePath( svgFilePath );
 }
 
 QgsSVGFillSymbolLayer::QgsSVGFillSymbolLayer( const QByteArray &svgData, double width, double angle )

Original file line number	Diff line number	Diff line change
`@@ -1722,11 +1722,10 @@ QgsSVGFillSymbolLayer::QgsSVGFillSymbolLayer( const QString &svgFilePath, double`
`1722`	`1722`	`: QgsImageFillSymbolLayer()`
`1723`	`1723`	`, mPatternWidth( width )`
`1724`	`1724`	`{`
`1725`		`- setSvgFilePath( svgFilePath );`
`1726`	`1725`	`mStrokeWidth = 0.3;`
`1727`	`1726`	`mAngle = angle;`
`1728`	`1727`	`mColor = QColor( 255, 255, 255 );`
`1729`		`- setDefaultSvgParams();`
	`1728`	`+ setSvgFilePath( svgFilePath );`
`1730`	`1729`	`}`
`1731`	`1730`
`1732`	`1731`	`QgsSVGFillSymbolLayer::QgsSVGFillSymbolLayer( const QByteArray &svgData, double width, double angle )`