Skip to content

Commit

Permalink
Add AnnotationLayer to layer item type enum, silence warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Aug 5, 2020
1 parent 9f943f7 commit 35d9a65
Show file tree
Hide file tree
Showing 17 changed files with 43 additions and 4 deletions.
2 changes: 2 additions & 0 deletions python/core/auto_additions/qgsmaplayer.py
Expand Up @@ -11,6 +11,8 @@
QgsMapLayer.MeshLayer.__doc__ = "Added in 3.2"
QgsMapLayer.VectorTileLayer = QgsMapLayerType.VectorTileLayer
QgsMapLayer.VectorTileLayer.__doc__ = "Added in 3.14"
QgsMapLayer.AnnotationLayer = QgsMapLayerType.AnnotationLayer
QgsMapLayer.AnnotationLayer.__doc__ = "Contains freeform, georeferenced annotations. Added in QGIS 3.10"
QgsMapLayerType.__doc__ = 'Types of layers that can be added to a map\n\n.. versionadded:: 3.8\n\n' + '* ``VectorLayer``: ' + QgsMapLayerType.VectorLayer.__doc__ + '\n' + '* ``RasterLayer``: ' + QgsMapLayerType.RasterLayer.__doc__ + '\n' + '* ``PluginLayer``: ' + QgsMapLayerType.PluginLayer.__doc__ + '\n' + '* ``MeshLayer``: ' + QgsMapLayerType.MeshLayer.__doc__ + '\n' + '* ``VectorTileLayer``: ' + QgsMapLayerType.VectorTileLayer.__doc__
# --
QgsMapLayer.LayerFlag.baseClass = QgsMapLayer
Expand Down
3 changes: 2 additions & 1 deletion python/core/auto_generated/qgsmaplayer.sip.in
Expand Up @@ -20,7 +20,8 @@ enum class QgsMapLayerType
RasterLayer,
PluginLayer,
MeshLayer,
VectorTileLayer
VectorTileLayer,
AnnotationLayer,
};

class QgsMapLayer : QObject
Expand Down
6 changes: 6 additions & 0 deletions src/analysis/processing/qgsalgorithmpackage.cpp
Expand Up @@ -183,6 +183,12 @@ QVariantMap QgsPackageAlgorithm::processAlgorithm( const QVariantMap &parameters
feedback->pushDebugInfo( QObject::tr( "Packaging vector tile layers is not supported." ) );
errored = true;
break;

case QgsMapLayerType::AnnotationLayer:
//not supported
feedback->pushDebugInfo( QObject::tr( "Packaging annotation layers is not supported." ) );
errored = true;
break;
}
}

Expand Down
1 change: 1 addition & 0 deletions src/app/browser/qgsinbuiltdataitemproviders.cpp
Expand Up @@ -451,6 +451,7 @@ void QgsLayerItemGuiProvider::populateContextMenu( QgsDataItem *item, QMenu *men
}

case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
case QgsMapLayerType::MeshLayer:
case QgsMapLayerType::VectorTileLayer:
break;
Expand Down
8 changes: 8 additions & 0 deletions src/app/qgisapp.cpp
Expand Up @@ -8688,6 +8688,7 @@ QString QgisApp::saveAsFile( QgsMapLayer *layer, const bool onlySelected, const
case QgsMapLayerType::MeshLayer:
case QgsMapLayerType::VectorTileLayer:
case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
return QString();
}
return QString();
Expand Down Expand Up @@ -14679,6 +14680,7 @@ void QgisApp::activateDeactivateLayerRelatedActions( QgsMapLayer *layer )
break;

case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
break;

}
Expand Down Expand Up @@ -15685,6 +15687,12 @@ void QgisApp::showLayerProperties( QgsMapLayer *mapLayer, const QString &page )
}
break;
}

case QgsMapLayerType::AnnotationLayer:
{
break;
}

}
}

Expand Down
1 change: 1 addition & 0 deletions src/app/qgsidentifyresultsdialog.cpp
Expand Up @@ -506,6 +506,7 @@ void QgsIdentifyResultsDialog::addFeature( const QgsMapToolIdentify::IdentifyRes
break;

case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
break;
}
}
Expand Down
3 changes: 3 additions & 0 deletions src/app/qgslayerstylingwidget.cpp
Expand Up @@ -242,6 +242,7 @@ void QgsLayerStylingWidget::setLayer( QgsMapLayer *layer )
}

case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
break;
}

Expand Down Expand Up @@ -645,6 +646,7 @@ void QgsLayerStylingWidget::updateCurrentWidgetLayer()
}

case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
{
mStackedWidget->setCurrentIndex( mNotSupportedPage );
break;
Expand Down Expand Up @@ -772,6 +774,7 @@ bool QgsLayerStyleManagerWidgetFactory::supportsLayer( QgsMapLayer *layer ) cons
return false; // TODO

case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
return false;
}
return false; // no warnings
Expand Down
2 changes: 2 additions & 0 deletions src/core/processing/qgsprocessingutils.cpp
Expand Up @@ -174,6 +174,8 @@ QgsMapLayer *QgsProcessingUtils::mapLayerFromStore( const QString &string, QgsMa
return !canUseLayer( qobject_cast< QgsMeshLayer * >( layer ) );
case QgsMapLayerType::VectorTileLayer:
return !canUseLayer( qobject_cast< QgsVectorTileLayer * >( layer ) );
case QgsMapLayerType::AnnotationLayer:
return true;
}
return true;
} ), layers.end() );
Expand Down
5 changes: 5 additions & 0 deletions src/core/qgsdataitem.cpp
Expand Up @@ -824,6 +824,8 @@ QgsLayerItem::LayerType QgsLayerItem::typeFromMapLayer( QgsMapLayer *layer )
return Mesh;
case QgsMapLayerType::VectorTileLayer:
return VectorTile;
case QgsMapLayerType::AnnotationLayer:
return Vector; // will never happen!
}
return Vector; // no warnings
}
Expand Down Expand Up @@ -925,6 +927,9 @@ QgsMimeDataUtils::Uri QgsLayerItem::mimeUri() const
case QgsMapLayerType::PluginLayer:
u.layerType = QStringLiteral( "plugin" );
break;
case QgsMapLayerType::AnnotationLayer:
u.layerType = QStringLiteral( "annotation" );
break;
}

u.providerKey = providerKey();
Expand Down
1 change: 1 addition & 0 deletions src/core/qgsmaplayer.h
Expand Up @@ -71,6 +71,7 @@ enum class QgsMapLayerType SIP_MONKEYPATCH_SCOPEENUM_UNNEST( QgsMapLayer, LayerT
PluginLayer,
MeshLayer, //!< Added in 3.2
VectorTileLayer //!< Added in 3.14
AnnotationLayer, //!< Contains freeform, georeferenced annotations. Added in QGIS 3.16
};

/**
Expand Down
1 change: 1 addition & 0 deletions src/core/qgsmimedatautils.cpp
Expand Up @@ -98,6 +98,7 @@ QgsMimeDataUtils::Uri::Uri( QgsMapLayer *layer )
}

case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
{
// plugin layers do not have a standard way of storing their URI...
return;
Expand Down
3 changes: 3 additions & 0 deletions src/gui/layertree/qgslayertreeembeddedwidgetsimpl.cpp
Expand Up @@ -74,6 +74,7 @@ QgsLayerTreeOpacityWidget::QgsLayerTreeOpacityWidget( QgsMapLayer *layer )
case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::MeshLayer:
case QgsMapLayerType::VectorTileLayer:
case QgsMapLayerType::AnnotationLayer:
break;

}
Expand Down Expand Up @@ -114,6 +115,7 @@ void QgsLayerTreeOpacityWidget::updateOpacityFromSlider()
case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::MeshLayer:
case QgsMapLayerType::VectorTileLayer:
case QgsMapLayerType::AnnotationLayer:
break;
}

Expand Down Expand Up @@ -156,6 +158,7 @@ bool QgsLayerTreeOpacityWidget::Provider::supportsLayer( QgsMapLayer *layer )
case QgsMapLayerType::MeshLayer:
case QgsMapLayerType::VectorTileLayer:
case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
return false;
}
return false;
Expand Down
1 change: 1 addition & 0 deletions src/gui/qgsbrowserdockwidget_p.cpp
Expand Up @@ -218,6 +218,7 @@ void QgsBrowserLayerProperties::setItem( QgsDataItem *item )
}

case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
{
// TODO: support display of properties for plugin layers
return;
Expand Down
1 change: 1 addition & 0 deletions src/gui/qgsidentifymenu.cpp
Expand Up @@ -131,6 +131,7 @@ QList<QgsMapToolIdentify::IdentifyResult> QgsIdentifyMenu::exec( const QList<Qgs
break;

case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
case QgsMapLayerType::MeshLayer:
break;
}
Expand Down
1 change: 1 addition & 0 deletions src/server/services/wms/qgswmsdescribelayer.cpp
Expand Up @@ -193,6 +193,7 @@ namespace QgsWms
case QgsMapLayerType::MeshLayer:
case QgsMapLayerType::VectorTileLayer:
case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
break;
}
layerNode.appendChild( typeNode );
Expand Down
1 change: 1 addition & 0 deletions src/server/services/wms/qgswmsgetcapabilities.cpp
Expand Up @@ -1982,6 +1982,7 @@ namespace QgsWms
case QgsMapLayerType::MeshLayer:
case QgsMapLayerType::VectorTileLayer:
case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
break;
}
}
Expand Down
7 changes: 4 additions & 3 deletions src/server/services/wms/qgswmsrenderer.cpp
Expand Up @@ -1685,9 +1685,9 @@ namespace QgsWms
}

const QgsRaster::IdentifyFormat identifyFormat { static_cast<bool>( layer->dataProvider()->capabilities() &
QgsRasterDataProvider::IdentifyFeature ) ?
QgsRaster::IdentifyFormat::IdentifyFormatFeature :
QgsRaster::IdentifyFormat::IdentifyFormatValue };
QgsRasterDataProvider::IdentifyFeature ) ?
QgsRaster::IdentifyFormat::IdentifyFormatFeature :
QgsRaster::IdentifyFormat::IdentifyFormatValue };

QgsRasterIdentifyResult identifyResult;
if ( layer->crs() != mapSettings.destinationCrs() )
Expand Down Expand Up @@ -2753,6 +2753,7 @@ namespace QgsWms
case QgsMapLayerType::MeshLayer:
case QgsMapLayerType::VectorTileLayer:
case QgsMapLayerType::PluginLayer:
case QgsMapLayerType::AnnotationLayer:
break;
}
}
Expand Down

0 comments on commit 35d9a65

Please sign in to comment.