Do not define in child class a member variable existing in parent class

qgis · Mar 6, 2021 · 351b73a · 351b73a
1 parent ae01f67
commit 351b73a
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 15 deletions.
diff --git a/src/gui/qgsmaptoolidentifyfeature.cpp b/src/gui/qgsmaptoolidentifyfeature.cpp
@@ -20,7 +20,6 @@
 
 QgsMapToolIdentifyFeature::QgsMapToolIdentifyFeature( QgsMapCanvas *canvas, QgsVectorLayer *vl )
   : QgsMapToolIdentify( canvas )
-  , mCanvas( canvas )
   , mLayer( vl )
 {
   mToolName = tr( "Identify feature" );

diff --git a/src/gui/qgsmaptoolidentifyfeature.h b/src/gui/qgsmaptoolidentifyfeature.h
@@ -51,7 +51,6 @@ class GUI_EXPORT QgsMapToolIdentifyFeature : public QgsMapToolIdentify
     void keyPressEvent( QKeyEvent *e ) override;
 
   private:
-    QgsMapCanvas *mCanvas = nullptr;
     QgsVectorLayer *mLayer = nullptr;
 };
 

diff --git a/src/plugins/grass/qgsgrassmoduleinput.cpp b/src/plugins/grass/qgsgrassmoduleinput.cpp
@@ -786,7 +786,6 @@ QgsGrassModuleInput::QgsGrassModuleInput( QgsGrassModule *module,
   , mModuleStandardOptions( options )
   , mUpdate( false )
   , mUsesRegion( false )
-  , mRequired( false )
 {
   mGeometryTypeMask = GV_POINT | GV_LINE | GV_AREA;
 
@@ -796,9 +795,6 @@ QgsGrassModuleInput::QgsGrassModuleInput( QgsGrassModule *module,
   }
   adjustTitle();
 
-  // Check if this parameter is required
-  mRequired = gnode.toElement().attribute( QStringLiteral( "required" ) ) == QLatin1String( "yes" );
-
   QDomNode promptNode = gnode.namedItem( QStringLiteral( "gisprompt" ) );
   QDomElement promptElem = promptNode.toElement();
   QString element = promptElem.attribute( QStringLiteral( "element" ) );

diff --git a/src/plugins/grass/qgsgrassmoduleinput.h b/src/plugins/grass/qgsgrassmoduleinput.h
@@ -350,9 +350,6 @@ class QgsGrassModuleInput : public QgsGrassModuleGroupBoxItem
     //! Uses region
     bool mUsesRegion;
 
-    //! Required field
-    bool mRequired;
-
     QgsGrassModuleInput( const QgsGrassModuleInput & ) = delete;
     QgsGrassModuleInput &operator = ( const QgsGrassModuleInput & ) = delete;
 };

diff --git a/src/plugins/grass/qgsgrassmoduleparam.cpp b/src/plugins/grass/qgsgrassmoduleparam.cpp
@@ -790,9 +790,6 @@ QgsGrassModuleGdalInput::QgsGrassModuleGdalInput(
   }
   adjustTitle();
 
-  // Check if this parameter is required
-  mRequired = gnode.toElement().attribute( QStringLiteral( "required" ) ) == QLatin1String( "yes" );
-
   // Read "layeroption" is defined
   QString opt = qdesc.attribute( QStringLiteral( "layeroption" ) );
   if ( ! opt.isNull() )

diff --git a/src/plugins/grass/qgsgrassmoduleparam.h b/src/plugins/grass/qgsgrassmoduleparam.h
@@ -421,9 +421,6 @@ class QgsGrassModuleGdalInput : public QgsGrassModuleGroupBoxItem
 
     //! Ogr where clauses
     QStringList mOgrWheres;
-
-    //! Required field
-    bool mRequired;
 };