Fix crash when trying to insert geometry into collection with bad index

nyalldawson · nyalldawson · commit 33ba9a8c48a1 · 2017-09-25T17:20:36.000+10:00
diff --git a/src/core/geometry/qgsgeometrycollection.cpp b/src/core/geometry/qgsgeometrycollection.cpp
@@ -128,6 +128,8 @@ bool QgsGeometryCollection::insertGeometry( QgsAbstractGeometry *g, int index )
     return false;
   }
 
+  index = std::min( mGeometries.count(), index );
+
   mGeometries.insert( index, g );
   clearCache(); //set bounding box invalid
   return true;

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,8 @@ bool QgsGeometryCollection::insertGeometry( QgsAbstractGeometry *g, int index )`
`128`	`128`	`return false;`
`129`	`129`	`}`
`130`	`130`
	`131`	`+ index = std::min( mGeometries.count(), index );`
	`132`	`+`
`131`	`133`	`mGeometries.insert( index, g );`
`132`	`134`	`clearCache(); //set bounding box invalid`
`133`	`135`	`return true;`