Skip to content

Commit 338b4c0

Browse files
DelazJ3nids
DelazJ
authored and
3nids
committedJul 2, 2017
Add catalog to spell_check
·
ltr-3_40final-3_0_0
1 parent e6a8e36 commit 338b4c0

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed
 

‎python/plugins/MetaSearch/dialogs/maindialog.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
QgsProviderRegistry, QgsSettings)
4848
from qgis.gui import QgsRubberBand
4949

50-
from owslib.csw import CatalogueServiceWeb
50+
from owslib.csw import CatalogueServiceWeb # spellok
5151
from owslib.fes import BBox, PropertyIsLike
5252
from owslib.ows import ExceptionReport
5353

@@ -821,7 +821,7 @@ def show_metadata(self):
821821

822822
try:
823823
QApplication.setOverrideCursor(QCursor(Qt.WaitCursor))
824-
cat = CatalogueServiceWeb(self.catalog_url, timeout=self.timeout,
824+
cat = CatalogueServiceWeb(self.catalog_url, timeout=self.timeout, # spellok
825825
username=self.catalog_username,
826826
password=self.catalog_password)
827827
cat.getrecordbyid(
@@ -899,12 +899,12 @@ def reject(self):
899899
self.rubber_band.reset()
900900

901901
def _get_csw(self):
902-
"""convenience function to init owslib.csw.CatalogueServiceWeb"""
902+
"""convenience function to init owslib.csw.CatalogueServiceWeb""" # spellok
903903

904904
# connect to the server
905905
try:
906906
QApplication.setOverrideCursor(QCursor(Qt.WaitCursor))
907-
self.catalog = CatalogueServiceWeb(self.catalog_url,
907+
self.catalog = CatalogueServiceWeb(self.catalog_url, # spellok
908908
timeout=self.timeout,
909909
username=self.catalog_username,
910910
password=self.catalog_password)

‎scripts/spell_check/.agignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ images/themes/default/propertyicons/diagram.svg
4040
images/themes/default/propertyicons/general.svg
4141
images/themes/default/svgbase/hammer.svg
4242
LexerR.py
43+
python/plugins/MetaSearch/resources/connections-default.xml
4344
python/plugins/processing/algs/grass7/description/i.landsat.toar.txt
4445
python/plugins/processing/gui/algnames.txt
4546
python/plugins/processing/tests/testdata/expected/orthagonal_lines.gfs

‎scripts/spell_check/spelling.dat

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1137,6 +1137,7 @@ casues:causes
11371137
casuing:causing
11381138
casulaties:casualties
11391139
casulaty:casualty
1140+
catalogue:catalog
11401141
catagories:categories
11411142
catagorized:categorized
11421143
catagory:category

5 commit comments

Comments
 (5)

3nids commented on Jul 6, 2017

@3nids
3nids
on Jul 6, 2017
Member

@DelazJ you missed some Catalogue fixes. Can you run ./scripts/spell_check/check_spelling.sh to fix these?

DelazJ commented on Jul 6, 2017

@DelazJ
DelazJ
on Jul 6, 2017
ContributorAuthor

@3nids I do not have a git infrastructure right now so I'm afraid it would only be in the evening.
Question: Isn't that run in the prepare-commit script (I set it to automatically run before each commit)?

3nids commented on Jul 6, 2017

@3nids
3nids
on Jul 6, 2017
Member

yep, but only on modified files (otherwise it would take too much time).
If you run the script directly (without argument), it runs on the whole source code.

DelazJ commented on Jul 6, 2017

@DelazJ
DelazJ
on Jul 6, 2017
ContributorAuthor

Hmmmm... It makes sense.
So it will replace all occurrences except in the agignored files and #spellok lines, right?
I had checked the behavior of thoses tools but the files I found were written in a programmatic (hence mainly cryptic for me) language so I had to guess and wait for reviewers comments and improvements. Unless I miss it, worth mention in QGIS Dev Guide?

3nids commented on Jul 6, 2017

@3nids
3nids
on Jul 6, 2017
Member

So it will replace all occurrences except in the agignored files and #spellok lines, right?

correct!

worth mention in QGIS Dev Guide?

yep, adding a small paragraph could be added next to indentation

Please sign in to comment.