"[GDAL provider] Set VRT_SHARED_SOURCE=NO configuration option by default (#16507)

rouault · rouault · commit 32dd2b68cdf4 · 2017-06-26T21:32:16.000+02:00
This will avoid crashes with VRT datasets in multi-threaded use.
diff --git a/src/providers/gdal/qgsgdalprovider.cpp b/src/providers/gdal/qgsgdalprovider.cpp
@@ -150,6 +150,14 @@ QgsGdalProvider::QgsGdalProvider( const QString &uri, bool update )
     CPLSetConfigOption( "AAIGRID_DATATYPE", "Float64" );
   }
 
+  if ( !CPLGetConfigOption( "VRT_SHARED_SOURCE", nullptr ) )
+  {
+    // GDAL version up to this date have issues will use of VRT in multi-threaded
+    // scenarios. See https://issues.qgis.org/issues/16507 /
+    // https://trac.osgeo.org/gdal/ticket/6939
+    CPLSetConfigOption( "VRT_SHARED_SOURCE", "NO" );
+  }
+
   // To get buildSupportedRasterFileFilter the provider is called with empty uri
   if ( uri.isEmpty() )
   {

Original file line number	Diff line number	Diff line change
`@@ -150,6 +150,14 @@ QgsGdalProvider::QgsGdalProvider( const QString &uri, bool update )`
`150`	`150`	`CPLSetConfigOption( "AAIGRID_DATATYPE", "Float64" );`
`151`	`151`	`}`
`152`	`152`
	`153`	`+ if ( !CPLGetConfigOption( "VRT_SHARED_SOURCE", nullptr ) )`
	`154`	`+ {`
	`155`	`+ // GDAL version up to this date have issues will use of VRT in multi-threaded`
	`156`	`+ // scenarios. See https://issues.qgis.org/issues/16507 /`
	`157`	`+ // https://trac.osgeo.org/gdal/ticket/6939`
	`158`	`+ CPLSetConfigOption( "VRT_SHARED_SOURCE", "NO" );`
	`159`	`+ }`
	`160`	`+`
`153`	`161`	`// To get buildSupportedRasterFileFilter the provider is called with empty uri`
`154`	`162`	`if ( uri.isEmpty() )`
`155`	`163`	`{`