Do not report envelope as gap

m-kuhn · m-kuhn · commit 32cdf3a0b261 · 2018-10-26T10:01:18.000+02:00
Under some circumstances, the envelope of a check region would be reported as a gap.
While a check that this doesn't happen is normally enforced, this check doesn't work
when the features happen to be placed unfortunate enough to have their bounding box
rounded differently than the envelope.
diff --git a/src/analysis/vector/geometry_checker/qgsgeometrygapcheck.cpp b/src/analysis/vector/geometry_checker/qgsgeometrygapcheck.cpp
@@ -98,7 +98,8 @@ void QgsGeometryGapCheck::collectErrors( const QMap<QString, QgsFeaturePool *> &
   {
     std::unique_ptr<QgsAbstractGeometry> gapGeom( QgsGeometryCheckerUtils::getGeomPart( diffGeom.get(), iPart )->clone() );
     // Skip the gap between features and boundingbox
-    if ( gapGeom->boundingBox() == envelope->boundingBox() )
+    const double spacing = context()->tolerance;
+    if ( gapGeom->boundingBox().snappedToGrid( spacing ) == envelope->boundingBox().snappedToGrid( spacing ) )
     {
       continue;
     }

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,8 @@ void QgsGeometryGapCheck::collectErrors( const QMap<QString, QgsFeaturePool *> &`
`98`	`98`	`{`
`99`	`99`	`std::unique_ptr<QgsAbstractGeometry> gapGeom( QgsGeometryCheckerUtils::getGeomPart( diffGeom.get(), iPart )->clone() );`
`100`	`100`	`// Skip the gap between features and boundingbox`
`101`		`- if ( gapGeom->boundingBox() == envelope->boundingBox() )`
	`101`	`+ const double spacing = context()->tolerance;`
	`102`	`+ if ( gapGeom->boundingBox().snappedToGrid( spacing ) == envelope->boundingBox().snappedToGrid( spacing ) )`
`102`	`103`	`{`
`103`	`104`	`continue;`
`104`	`105`	`}`