Fix broken atlas handling of z/m layer types

nyalldawson · nyalldawson · commit 327d311e2135 · 2018-01-05T11:15:03.000+10:00
diff --git a/src/app/layout/qgslayoutmapwidget.cpp b/src/app/layout/qgslayoutmapwidget.cpp
@@ -695,21 +695,18 @@ void QgsLayoutMapWidget::toggleAtlasScalingOptionsByLayerType()
     return;
   }
 
-  switch ( layer->wkbType() )
-  {
-    case QgsWkbTypes::Point:
-    case QgsWkbTypes::Point25D:
-    case QgsWkbTypes::MultiPoint:
-    case QgsWkbTypes::MultiPoint25D:
-      //For point layers buffer setting makes no sense, so set "fixed scale" on and disable margin control
-      mAtlasFixedScaleRadio->setChecked( true );
-      mAtlasMarginRadio->setEnabled( false );
-      mAtlasPredefinedScaleRadio->setEnabled( false );
-      break;
-    default:
-      //Not a point layer, so enable changes to fixed scale control
-      mAtlasMarginRadio->setEnabled( true );
-      mAtlasPredefinedScaleRadio->setEnabled( true );
+  if ( QgsWkbTypes::geometryType( layer->wkbType() ) == QgsWkbTypes::PointGeometry )
+  {
+    //For point layers buffer setting makes no sense, so set "fixed scale" on and disable margin control
+    mAtlasFixedScaleRadio->setChecked( true );
+    mAtlasMarginRadio->setEnabled( false );
+    mAtlasPredefinedScaleRadio->setEnabled( false );
+  }
+  else
+  {
+    //Not a point layer, so enable changes to fixed scale control
+    mAtlasMarginRadio->setEnabled( true );
+    mAtlasPredefinedScaleRadio->setEnabled( true );
   }
 }
 
diff --git a/src/core/layout/qgslayoutitemmap.cpp b/src/core/layout/qgslayoutitemmap.cpp
@@ -1825,19 +1825,7 @@ void QgsLayoutItemMap::updateAtlasFeature()
   QgsRectangle originalExtent = mExtent;
 
   //sanity check - only allow fixed scale mode for point layers
-  bool isPointLayer = false;
-  switch ( mLayout->context().layer()->wkbType() )
-  {
-    case QgsWkbTypes::Point:
-    case QgsWkbTypes::Point25D:
-    case QgsWkbTypes::MultiPoint:
-    case QgsWkbTypes::MultiPoint25D:
-      isPointLayer = true;
-      break;
-    default:
-      isPointLayer = false;
-      break;
-  }
+  bool isPointLayer = QgsWkbTypes::geometryType( mLayout->context().layer()->wkbType() ) == QgsWkbTypes::PointGeometry;
 
   if ( mAtlasScalingMode == Fixed || mAtlasScalingMode == Predefined || isPointLayer )
   {
