Partially fix of #39855: diminfo in inserted as string in mdsys query

rduivenvoorde · rduivenvoorde · commit 31a0e72147b1 · 2020-11-16T17:03:08.000+01:00
By inserting the diminfo string into the query instead of giving it as a param in the prepared statement, the error is fixed. Apparently the param was resolved as a string? Note that this NOT fix the dbmanager issue of #39855. But it makes it possible to drag/drop a layer from the browser again.
diff --git a/src/providers/oracle/qgsoracleprovider.cpp b/src/providers/oracle/qgsoracleprovider.cpp
@@ -3093,8 +3093,8 @@ QgsVectorLayerExporter::ExportError QgsOracleProvider::createEmptyLayer(
       }
     }
 
-    if ( !exec( qry, QString( "INSERT INTO mdsys.user_sdo_geom_metadata(table_name,column_name,srid,diminfo) VALUES (?,?,?,?)" ),
-                QVariantList() << tableName.toUpper() << geometryColumn.toUpper() << srid << diminfo ) )
+    if ( !exec( qry, QString( "INSERT INTO mdsys.user_sdo_geom_metadata(table_name,column_name,srid,diminfo) VALUES (?,?,?,%1)" ).arg( QString( diminfo ) ),
+                QVariantList() << tableName.toUpper() << geometryColumn.toUpper() << srid ) )
     {
       throw OracleException( tr( "Could not insert metadata." ), qry );
     }

Original file line number	Diff line number	Diff line change
`@@ -3093,8 +3093,8 @@ QgsVectorLayerExporter::ExportError QgsOracleProvider::createEmptyLayer(`
`3093`	`3093`	`}`
`3094`	`3094`	`}`
`3095`	`3095`
`3096`		`- if ( !exec( qry, QString( "INSERT INTO mdsys.user_sdo_geom_metadata(table_name,column_name,srid,diminfo) VALUES (?,?,?,?)" ),`
`3097`		`- QVariantList() << tableName.toUpper() << geometryColumn.toUpper() << srid << diminfo ) )`
	`3096`	`+ if ( !exec( qry, QString( "INSERT INTO mdsys.user_sdo_geom_metadata(table_name,column_name,srid,diminfo) VALUES (?,?,?,%1)" ).arg( QString( diminfo ) ),`
	`3097`	`+ QVariantList() << tableName.toUpper() << geometryColumn.toUpper() << srid ) )`
`3098`	`3098`	`{`
`3099`	`3099`	`throw OracleException( tr( "Could not insert metadata." ), qry );`
`3100`	`3100`	`}`