Remove Q_FOREACH from modeltest

m-kuhn · m-kuhn · commit 31981123d495 · 2019-04-05T15:30:03.000+02:00
diff --git a/tests/qt_modeltest/dynamictreemodel.cpp b/tests/qt_modeltest/dynamictreemodel.cpp
@@ -255,7 +255,7 @@ void ModelMoveCommand::doCommand()
 
   for ( int column = 0; column < m_numCols; ++column )
   {
-    QList<qint64> l = m_model->m_childItems.value( srcParent.internalId() )[column].mid( m_startRow, m_endRow - m_startRow + 1 );
+    const QList<qint64> l = m_model->m_childItems.value( srcParent.internalId() )[column].mid( m_startRow, m_endRow - m_startRow + 1 );
 
     for ( int i = m_startRow; i <= m_endRow ; i++ )
     {
@@ -272,7 +272,7 @@ void ModelMoveCommand::doCommand()
         d = m_destRow - ( m_endRow - m_startRow ) + 1;
     }
 
-    Q_FOREACH ( const qint64 id, l )
+    for ( const qint64 id : l )
     {
       m_model->m_childItems[destParent.internalId()][column].insert( d++, id );
     }

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,7 @@ void ModelMoveCommand::doCommand()`
`255`	`255`
`256`	`256`	`for ( int column = 0; column < m_numCols; ++column )`
`257`	`257`	`{`
`258`		`- QList<qint64> l = m_model->m_childItems.value( srcParent.internalId() )[column].mid( m_startRow, m_endRow - m_startRow + 1 );`
	`258`	`+ const QList<qint64> l = m_model->m_childItems.value( srcParent.internalId() )[column].mid( m_startRow, m_endRow - m_startRow + 1 );`
`259`	`259`
`260`	`260`	`for ( int i = m_startRow; i <= m_endRow ; i++ )`
`261`	`261`	`{`
`@@ -272,7 +272,7 @@ void ModelMoveCommand::doCommand()`
`272`	`272`	`d = m_destRow - ( m_endRow - m_startRow ) + 1;`
`273`	`273`	`}`
`274`	`274`
`275`		`- Q_FOREACH ( const qint64 id, l )`
	`275`	`+ for ( const qint64 id : l )`
`276`	`276`	`{`
`277`	`277`	`m_model->m_childItems[destParent.internalId()][column].insert( d++, id );`
`278`	`278`	`}`