Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
fix windows build
- Loading branch information
Showing
1 changed file
with
9 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
314d144
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Juergen! I had not noticed this commit and was just drafting a feature request to ask a Windows developer to add this functionality, when I finally ran across it.
Do you think envVarName.toUtf8() should be switched to envVarName.toLocal8Bit(), or maybe envVarName.toAscii() ? I think envVarValue.toUtf8().constData() makes sense. I'm not just not sure (not enough experience to know) if UTF8 is supported at this level for all operating systems running QGIS. Pretty sure it is for Linux and Mac.
314d144
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I mention the possible change is that there has been an issue where the custom variables appear to not work on Windows, even for an administrator user:
http://hub.qgis.org/issues/6961
Regis tested with a build several commits after this one.