Optimise QgsRectangle::asWktPolygon

Avoid multiple string allocations
qgis · Oct 6, 2023 · 3137b21 · 3137b21
1 parent d9d531e
commit 3137b21
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/src/core/geometry/qgsrectangle.cpp b/src/core/geometry/qgsrectangle.cpp
@@ -122,16 +122,12 @@ QString QgsRectangle::asWktPolygon() const
     return QStringLiteral( "POLYGON EMPTY" );
   }
 
-  QString rep =
-    QLatin1String( "POLYGON((" ) +
-    qgsDoubleToString( mXmin ) + ' ' + qgsDoubleToString( mYmin ) + QLatin1String( ", " ) +
-    qgsDoubleToString( mXmax ) + ' ' + qgsDoubleToString( mYmin ) + QLatin1String( ", " ) +
-    qgsDoubleToString( mXmax ) + ' ' + qgsDoubleToString( mYmax ) + QLatin1String( ", " ) +
-    qgsDoubleToString( mXmin ) + ' ' + qgsDoubleToString( mYmax ) + QLatin1String( ", " ) +
-    qgsDoubleToString( mXmin ) + ' ' + qgsDoubleToString( mYmin ) +
-    QStringLiteral( "))" );
-
-  return rep;
+  return QStringLiteral( "POLYGON((%1 %2, %3 %2, %3 %4, %1 %4, %1 %2))" ).arg(
+           qgsDoubleToString( mXmin ),
+           qgsDoubleToString( mYmin ),
+           qgsDoubleToString( mXmax ),
+           qgsDoubleToString( mYmax )
+         );
 }
 
 QString QgsRectangle::toString( int precision ) const