[attributetable] No autofallback to FilterMode::ShowVisible

As soon as extents of the map canvas changed, the filter showvisible was reapplied without a reason
qgis · Apr 19, 2013 · 310e2de · 310e2de
1 parent bfef00a
commit 310e2de
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/gui/attributetable/qgsattributetablefiltermodel.cpp b/src/gui/attributetable/qgsattributetablefiltermodel.cpp
@@ -123,7 +123,7 @@ bool QgsAttributeTableFilterModel::selectedOnTop()
 void QgsAttributeTableFilterModel::setFilteredFeatures( QgsFeatureIds ids )
 {
   mFilteredFeatures = ids;
-  mFilterMode = ShowFilteredList;
+  setFilterMode( ShowFilteredList );
   invalidateFilter();
 }
 
@@ -133,12 +133,12 @@ void QgsAttributeTableFilterModel::setFilterMode( FilterMode filterMode )
   {
     if ( filterMode == ShowVisible )
     {
-      connect( mCanvas, SIGNAL( extentsChanged() ), SLOT( extentsChanged() ) );
+      connect( mCanvas, SIGNAL( extentsChanged() ), this, SLOT( extentsChanged() ) );
       generateListOfVisibleFeatures();
     }
     else
     {
-      disconnect( SLOT( extentsChanged() ) );
+      disconnect( mCanvas, SIGNAL( extentsChanged() ), this, SLOT( extentsChanged() ) );
     }
 
     if ( filterMode == ShowSelected )