Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
elpaso authored and nyalldawson committed Nov 4, 2021
1 parent c5f956d commit 2fbb830
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8 deletions.
5 changes: 1 addition & 4 deletions python/core/auto_additions/qgis.py
Expand Up @@ -72,13 +72,10 @@
# --
Qgis.DataType.baseClass = Qgis
# monkey patching scoped based enum
Qgis.SqlQuery = Qgis.VectorLayerTypeFlag.SqlQuery
Qgis.SqlQuery.is_monkey_patched = True
Qgis.SqlQuery.__doc__ = "SQL query layer"
Qgis.VectorLayerTypeFlag.SqlQuery.__doc__ = "SQL query layer"
Qgis.VectorLayerTypeFlag.__doc__ = 'Vector layer type flags.\n\n.. versionadded:: 3.24\n\n' + '* ``SqlQuery``: ' + Qgis.VectorLayerTypeFlag.SqlQuery.__doc__
# --
Qgis.VectorLayerTypeFlag.baseClass = Qgis
QgsVectorLayer.VectorLayerTypeFlags = Qgis.VectorLayerTypeFlags
# monkey patching scoped based enum
Qgis.Never = Qgis.PythonMacroMode.Never
Qgis.Never.is_monkey_patched = True
Expand Down
2 changes: 1 addition & 1 deletion python/core/auto_generated/qgis.sip.in
Expand Up @@ -104,7 +104,7 @@ The development version
};

enum class VectorLayerTypeFlag
{
{
SqlQuery
};
typedef QFlags<Qgis::VectorLayerTypeFlag> VectorLayerTypeFlags;
Expand Down
6 changes: 3 additions & 3 deletions src/core/qgis.h
Expand Up @@ -140,13 +140,13 @@ class CORE_EXPORT Qgis
*
* \since QGIS 3.24
*/
enum class VectorLayerTypeFlag SIP_MONKEYPATCH_SCOPEENUM_UNNEST( Qgis, VectorLayerTypeFlag ) : int
{
enum class VectorLayerTypeFlag : int
{
SqlQuery = 1 << 0 //!< SQL query layer
};
Q_ENUM( VectorLayerTypeFlag )
//! Vector layer type flags
Q_DECLARE_FLAGS( VectorLayerTypeFlags, VectorLayerTypeFlag ) SIP_MONKEYPATCH_FLAGS_UNNEST( QgsVectorLayer, VectorLayerTypeFlags )
Q_DECLARE_FLAGS( VectorLayerTypeFlags, VectorLayerTypeFlag )


/**
Expand Down

0 comments on commit 2fbb830

Please sign in to comment.