Fix build against recent sip/PyQt4:

qgsfiledownloader.sip:33:0: src/gui/qgsfiledownloader.h:94:5: error: overriding non-deleted function 'virtual QgsFileDownloader::~QgsFileDownloader()' RuntimeError: qgis._core cannot import type 'QList<QVariant>' from PyQt4.QtCore (cherry picked from commit 85a0db2) fixes #16071
qgis · Mar 4, 2017 · 2efb2a3 · 2efb2a3 · Scimmia22 · Mar 8, 2017
1 parent b86db94
commit 2efb2a3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/python/core/core.sip b/python/core/core.sip
@@ -3,6 +3,7 @@
 
 %Feature QT5_SUPPORT
 
+%Import QtCore/QtCoremod.sip
 %Import QtXml/QtXmlmod.sip
 %Import QtNetwork/QtNetworkmod.sip
 %Import QtSql/QtSqlmod.sip

diff --git a/src/gui/qgsfiledownloader.h b/src/gui/qgsfiledownloader.h
@@ -90,8 +90,10 @@ class GUI_EXPORT QgsFileDownloader : public QObject
     void onSslErrors( QNetworkReply *reply, const QList<QSslError> &errors );
 #endif
 
-  private:
+  protected:
     ~QgsFileDownloader();
+
+  private:
     /**
      * Abort current request and show an error if the instance has GUI
      * notifications enabled.