Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Address review
  • Loading branch information
nirvn committed Mar 5, 2021
1 parent f2b4948 commit 2de94aa
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
Expand Up @@ -41,14 +41,20 @@ QString QgsBatchNominatimGeocodeAlgorithm::displayName() const

QStringList QgsBatchNominatimGeocodeAlgorithm::tags() const
{
return QObject::tr( "geocode,nominatim,batch" ).split( ',' );
return QObject::tr( "geocode,nominatim,batch,bulk,address,match" ).split( ',' );
}

QgsBatchNominatimGeocodeAlgorithm *QgsBatchNominatimGeocodeAlgorithm::createInstance() const
{
return new QgsBatchNominatimGeocodeAlgorithm();
}

QString QgsBatchNominatimGeocodeAlgorithm::shortHelpString() const
{
return QObject::tr( "This algorithm performs batch geocoding using the <a href=\"#\">Nominatim</a> service against an input layer string field.\n\n"
"The output layer will have a point geometry reflecting the geocoded location as well as a number of attributes associated to the geocoded location." );
}

bool QgsBatchNominatimGeocodeAlgorithm::prepareAlgorithm( const QVariantMap &parameters, QgsProcessingContext &context, QgsProcessingFeedback *feedback )
{
feedback->pushInfo( QObject::tr( "The Nominatim geocoder data is made available by OpenStreetMap Foundation and contributors. "
Expand Down
Expand Up @@ -44,6 +44,7 @@ class QgsBatchNominatimGeocodeAlgorithm : public QgsBatchGeocodeAlgorithm
QString name() const override;
QString displayName() const override;
QStringList tags() const override;
QString shortHelpString() const override;
QgsBatchNominatimGeocodeAlgorithm *createInstance() const override SIP_FACTORY;

protected:
Expand Down
2 changes: 1 addition & 1 deletion src/app/locator/qgsinbuiltlocatorfilters.cpp
Expand Up @@ -1194,7 +1194,7 @@ void QgsGotoLocatorFilter::triggerResult( const QgsLocatorResult &result )
}

QgsNominatimLocatorFilter::QgsNominatimLocatorFilter( QgsGeocoderInterface *geocoder, QgsMapCanvas *canvas )
: QgsGeocoderLocatorFilter( QStringLiteral( "nominatimgeocoder" ), tr( "Nominatim Geocoder" ), QStringLiteral( "nom" ), geocoder, canvas )
: QgsGeocoderLocatorFilter( QStringLiteral( "nominatimgeocoder" ), tr( "Nominatim Geocoder" ), QStringLiteral( ">" ), geocoder, canvas )
{
setFetchResultsDelay( 1000 );
setUseWithoutPrefix( false );
Expand Down
2 changes: 1 addition & 1 deletion src/app/qgisapp.cpp
Expand Up @@ -3918,7 +3918,7 @@ void QgisApp::createStatusBar()
mLocatorWidget->locator()->registerFilter( new QgsSettingsLocatorFilter() );
mLocatorWidget->locator()->registerFilter( new QgsGotoLocatorFilter() );

mNominatimGeocoder.reset( new QgsNominatimGeocoder() );
mNominatimGeocoder = qgis::make_unique< QgsNominatimGeocoder>();
mLocatorWidget->locator()->registerFilter( new QgsNominatimLocatorFilter( mNominatimGeocoder.get(), mMapCanvas ) );
}

Expand Down

0 comments on commit 2de94aa

Please sign in to comment.