Avoid a segfault when NULL layer is passed to vector writer

wonder-sk · wonder-sk · commit 2d35b16aaeb0 · 2011-08-04T19:50:19.000+02:00
diff --git a/python/core/qgsvectorfilewriter.sip b/python/core/qgsvectorfilewriter.sip
@@ -21,7 +21,12 @@ public:
       NoError = 0,
       ErrDriverNotFound,
       ErrCreateDataSource,
-      ErrCreateLayer
+      ErrCreateLayer,
+      ErrAttributeTypeUnsupported,
+      ErrAttributeCreationFailed,
+      ErrProjection,  // added in 1.5
+      ErrFeatureWriteFailed, // added in 1.6
+      ErrInvalidLayer, // added in 2.0
     };
 
     /** Write contents of vector layer to a shapefile 
diff --git a/src/core/qgsvectorfilewriter.cpp b/src/core/qgsvectorfilewriter.cpp
@@ -588,6 +588,11 @@ QgsVectorFileWriter::writeAsVectorFormat( QgsVectorLayer* layer,
   QgsCoordinateTransform* ct = 0;
   int shallTransform = false;
 
+  if ( layer == NULL )
+  {
+    return ErrInvalidLayer;
+  }
+
   if ( destCRS && destCRS->isValid() )
   {
     // This means we should transform
diff --git a/src/core/qgsvectorfilewriter.h b/src/core/qgsvectorfilewriter.h
@@ -53,6 +53,7 @@ class CORE_EXPORT QgsVectorFileWriter
       ErrAttributeCreationFailed,
       ErrProjection,  // added in 1.5
       ErrFeatureWriteFailed, // added in 1.6
+      ErrInvalidLayer, // added in 2.0
     };
 
     /** Write contents of vector layer to a shapefile
