Use const pointer for QgsExpression:replaceExpressionText()

qgis · Oct 10, 2013 · 2cd8938 · 2cd8938
1 parent f49ea36
commit 2cd8938
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 19 deletions.
diff --git a/python/core/qgsexpression.sip b/python/core/qgsexpression.sip
@@ -75,7 +75,7 @@ class QgsExpression
        Additional substitutions can be passed through the substitutionMap
        parameter
     */
-    static QString replaceExpressionText( QString action, QgsFeature &feat,
+    static QString replaceExpressionText( QString action, const QgsFeature *feat,
                                           QgsVectorLayer* layer,
                                           const QMap<QString, QVariant> *substitutionMap = 0 );
     //

diff --git a/src/core/qgsattributeaction.cpp b/src/core/qgsattributeaction.cpp
@@ -77,7 +77,7 @@ void QgsAttributeAction::doAction( int index, QgsFeature &feat,
     return;
 
   // search for expressions while expanding actions
-  QString expandedAction = QgsExpression::replaceExpressionText( action.action(), feat, mLayer , substitutionMap );
+  QString expandedAction = QgsExpression::replaceExpressionText( action.action(), &feat, mLayer , substitutionMap );
   if ( expandedAction.isEmpty() )
     return;
 

diff --git a/src/core/qgsexpression.cpp b/src/core/qgsexpression.cpp
@@ -1721,7 +1721,7 @@ void QgsExpression::acceptVisitor( QgsExpression::Visitor& v ) const
     mRootNode->accept( v );
 }
 
-QString QgsExpression::replaceExpressionText( QString action, QgsFeature* feat,
+QString QgsExpression::replaceExpressionText( QString action, const QgsFeature* feat,
     QgsVectorLayer* layer,
     const QMap<QString, QVariant> *substitutionMap )
 {
@@ -1796,14 +1796,6 @@ QString QgsExpression::replaceExpressionText( QString action, QgsFeature* feat,
 }
 
 
-QString QgsExpression::replaceExpressionText( QString action, QgsFeature& feat,
-    QgsVectorLayer* layer,
-    const QMap<QString, QVariant> *substitutionMap )
-{
-  return replaceExpressionText( action, &feat, layer, substitutionMap );
-}
-
-
 ///////////////////////////////////////////////
 // nodes
 

diff --git a/src/core/qgsexpression.h b/src/core/qgsexpression.h
@@ -171,12 +171,7 @@ class CORE_EXPORT QgsExpression
        Additional substitutions can be passed through the substitutionMap
        parameter
     */
-    static QString replaceExpressionText( QString action, QgsFeature* feat,
-                                          QgsVectorLayer* layer,
-                                          const QMap<QString, QVariant> *substitutionMap = 0 );
-
-
-    static QString replaceExpressionText( QString action, QgsFeature& feat,
+    static QString replaceExpressionText( const QString action, const QgsFeature* feat,
                                           QgsVectorLayer* layer,
                                           const QMap<QString, QVariant> *substitutionMap = 0 );
     enum UnaryOperator

diff --git a/src/gui/qgshtmlannotationitem.cpp b/src/gui/qgshtmlannotationitem.cpp
@@ -211,7 +211,7 @@ void QgsHtmlAnnotationItem::setFeatureForMapPosition()
   mFeatureId = currentFeatureId;
   mFeature = currentFeature;
 
-  QString newtext = QgsExpression::replaceExpressionText( mHtmlSource, mFeature, vectorLayer() );
+  QString newtext = QgsExpression::replaceExpressionText( mHtmlSource, &mFeature, vectorLayer() );
   mWebView->setHtml( newtext );
 }
 

diff --git a/src/gui/qgsmaptip.cpp b/src/gui/qgsmaptip.cpp
@@ -100,7 +100,7 @@ QString QgsMapTip::fetchFeature( QgsMapLayer *layer, QgsPoint &mapPosition, QgsM
 
   int idx = vlayer->fieldNameIndex( vlayer->displayField() );
   if ( idx < 0 )
-    return QgsExpression::replaceExpressionText( vlayer->displayField(), feature, vlayer );
+    return QgsExpression::replaceExpressionText( vlayer->displayField(), &feature, vlayer );
   else
     return feature.attribute( idx ).toString();
 }