Fix cannot set tolerance unit in simplify tool

nyalldawson · nyalldawson · commit 2b8519c0177b · 2018-03-26T14:27:15.000+10:00
diff --git a/src/app/qgsmaptoolsimplify.cpp b/src/app/qgsmaptoolsimplify.cpp
@@ -165,8 +165,10 @@ void QgsMapToolSimplify::setTolerance( double tolerance )
     updateSimplificationPreview();
 }
 
-void QgsMapToolSimplify::setToleranceUnits( const QgsTolerance::UnitType &units )
+void QgsMapToolSimplify::setToleranceUnits( QgsTolerance::UnitType units )
 {
+  mToleranceUnits = units;
+
   QgsSettings settings;
   settings.setValue( QStringLiteral( "digitizing/simplify_tolerance_units" ), units );
 
diff --git a/src/app/qgsmaptoolsimplify.h b/src/app/qgsmaptoolsimplify.h
@@ -73,7 +73,7 @@ class APP_EXPORT QgsMapToolSimplify: public QgsMapToolEdit
     //! Slot to change display when slidebar is moved
     void setTolerance( double tolerance );
 
-    void setToleranceUnits( const QgsTolerance::UnitType &units );
+    void setToleranceUnits( QgsTolerance::UnitType units );
 
     //! Slot to store feature after simplification
     void storeSimplified();

Original file line number	Diff line number	Diff line change
`@@ -165,8 +165,10 @@ void QgsMapToolSimplify::setTolerance( double tolerance )`
`165`	`165`	`updateSimplificationPreview();`
`166`	`166`	`}`
`167`	`167`
`168`		`-void QgsMapToolSimplify::setToleranceUnits( const QgsTolerance::UnitType &units )`
	`168`	`+void QgsMapToolSimplify::setToleranceUnits( QgsTolerance::UnitType units )`
`169`	`169`	`{`
	`170`	`+ mToleranceUnits = units;`
	`171`	`+`
`170`	`172`	`QgsSettings settings;`
`171`	`173`	`settings.setValue( QStringLiteral( "digitizing/simplify_tolerance_units" ), units );`
`172`	`174`