Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Only skip *.cpp files for doc generation on travis
- Loading branch information
Showing
3 changed files
with
5 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b7c5c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn I wonder if this whole change should be reverted. Given that the actual docs are built using the cpp files too, it seems pointless to not test these on Travis. Otherwise we get test failures on the nightly builds but not Travis...
2b7c5c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point for this was to exclude doxymentation in cpp files from the public API (since they are not public API) and from the documentation coverage threshold.
2b7c5c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn yes, but isn't the public doxygen docs generated from the nightly builds? So they would still including any classes defined in a .cpp file. I'd prefer to keep checking them in Travis, so we know that they need to be @cond'ed out to avoid them appearing in any public docs...