Skip to content

Commit

Permalink
Allow keyword arguments for all arguments in PyQGIS bindings
Browse files Browse the repository at this point in the history
Previously this was only enabled for optional arguments (i.e.
those with default values). Enabling them for all arguments
allows for more readable PyQGIS code, and there seems no
downside given that we already have this support partly enabled.

The consequence of this change is that when 3.0 API is frozen
the freeze must also include the naming of function arguments,
since that's effectively now part of public API.
  • Loading branch information
nyalldawson committed Jun 25, 2017
1 parent 69af2f5 commit 2b7b0db
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion python/analysis/analysis.sip
@@ -1,5 +1,5 @@
%Module(name=qgis._analysis,
keyword_arguments="Optional")
keyword_arguments="All")

%Import QtCore/QtCoremod.sip
%Import QtGui/QtGuimod.sip
Expand Down
2 changes: 1 addition & 1 deletion python/core/core.sip
@@ -1,5 +1,5 @@
%Module(name=qgis._core,
keyword_arguments="Optional")
keyword_arguments="All")

%ModuleCode

Expand Down
2 changes: 1 addition & 1 deletion python/gui/gui.sip
@@ -1,5 +1,5 @@
%Module(name=qgis._gui,
keyword_arguments="Optional")
keyword_arguments="All")

%Feature HAVE_QSCI_SIP

Expand Down
2 changes: 1 addition & 1 deletion python/server/server.sip
@@ -1,5 +1,5 @@
%Module(name=qgis._server,
keyword_arguments="Optional")
keyword_arguments="All")


%Import QtCore/QtCoremod.sip
Expand Down

0 comments on commit 2b7b0db

Please sign in to comment.