Skip to content

Commit 2af1e9f

Browse files
dakcartodakcarto
committedMar 9, 2017
Skip WMS_GetPrint_SRS test in PyQgsServer, instead of commenting out
As per discussion with Alessandro Pasotti
·
ltr-3_40final-3_0_0
1 parent bed3af2 commit 2af1e9f

File tree

1 file changed

+18
-17
lines changed

1 file changed

+18
-17
lines changed
 

‎tests/src/python/test_qgsserver.py

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -737,23 +737,24 @@ def test_wms_getprint_basic(self):
737737
r, h = self._result(self.server.handleRequest(qs))
738738
self._img_diff_error(r, h, "WMS_GetPrint_Basic")
739739

740-
# def test_wms_getprint_srs(self):
741-
# qs = "&".join(["%s=%s" % i for i in list({
742-
# "MAP": urllib.parse.quote(self.projectPath),
743-
# "SERVICE": "WMS",
744-
# "VERSION": "1.1.1",
745-
# "REQUEST": "GetPrint",
746-
# "TEMPLATE": "layoutA4",
747-
# "FORMAT": "png",
748-
# "map0:EXTENT": "-309.015,-133.011,312.179,133.949",
749-
# "map0:LAYERS": "Country,Hello",
750-
# "HEIGHT": "500",
751-
# "WIDTH": "500",
752-
# "CRS": "EPSG:4326"
753-
# }.items())])
754-
#
755-
# r, h = self._result(self.server.handleRequest(qs))
756-
# self._img_diff_error(r, h, "WMS_GetPrint_SRS")
740+
@unittest.skip('Randomly failing to draw the map layer')

Comment on line R740

m-kuhn commented on Mar 10, 2017

@m-kuhn
m-kuhn
on Mar 10, 2017
Member

Looks much better.
What do you think about adding a condition here. Something like

@unittest.skipIf(os.environ['TRAVIS'] == 'true', 'Randomly failing to draw the map layer')

This will improve the chance that someone discovers the test failing on his system (although that he realizes that this is interesting is still unlikely)

CC @elpaso

elpaso replied on Mar 10, 2017

@elpaso
elpaso
on Mar 10, 2017
Contributor

@m-kuhn Yes, that's a good idea!

Code has comments. Press enter to view.
741+
def test_wms_getprint_srs(self):
742+
qs = "&".join(["%s=%s" % i for i in list({
743+
"MAP": urllib.parse.quote(self.projectPath),
744+
"SERVICE": "WMS",
745+
"VERSION": "1.1.1",
746+
"REQUEST": "GetPrint",
747+
"TEMPLATE": "layoutA4",
748+
"FORMAT": "png",
749+
"map0:EXTENT": "-309.015,-133.011,312.179,133.949",
750+
"map0:LAYERS": "Country,Hello",
751+
"HEIGHT": "500",
752+
"WIDTH": "500",
753+
"CRS": "EPSG:4326"
754+
}.items())])
755+
756+
r, h = self._result(self.server.handleRequest(qs))
757+
self._img_diff_error(r, h, "WMS_GetPrint_SRS")
757758

758759
def test_wms_getprint_scale(self):
759760
qs = "&".join(["%s=%s" % i for i in list({

0 commit comments

Comments
 (0)
Please sign in to comment.