Avoid working on temporary geometries

m-kuhn · m-kuhn · commit 2ae8f3659fc6 · 2019-03-18T17:37:24.000+01:00
diff --git a/src/analysis/vector/geometry_checker/qgsgeometrycheckerror.cpp b/src/analysis/vector/geometry_checker/qgsgeometrycheckerror.cpp
@@ -53,7 +53,8 @@ QgsGeometryCheckError::QgsGeometryCheckError( const QgsGeometryCheck *check,
 {
   if ( vidx.part != -1 )
   {
-    mGeometry = QgsGeometry( QgsGeometryCheckerUtils::getGeomPart( layerFeature.geometry().constGet(), vidx.part )->clone() );
+    const QgsGeometry geom = layerFeature.geometry();
+    mGeometry = QgsGeometry( QgsGeometryCheckerUtils::getGeomPart( geom.constGet(), vidx.part )->clone() );
   }
   else
   {

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,8 @@ QgsGeometryCheckError::QgsGeometryCheckError( const QgsGeometryCheck *check,`
`53`	`53`	`{`
`54`	`54`	`if ( vidx.part != -1 )`
`55`	`55`	`{`
`56`		`- mGeometry = QgsGeometry( QgsGeometryCheckerUtils::getGeomPart( layerFeature.geometry().constGet(), vidx.part )->clone() );`
	`56`	`+ const QgsGeometry geom = layerFeature.geometry();`
	`57`	`+ mGeometry = QgsGeometry( QgsGeometryCheckerUtils::getGeomPart( geom.constGet(), vidx.part )->clone() );`
`57`	`58`	`}`
`58`	`59`	`else`
`59`	`60`	`{`